Comment 1 for bug 1848019

Reviewed: https://review.opendev.org/688390
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=52cac09d3d0b8dcdbc8d68a0bcc8092008220309
Submitter: Zuul
Branch: master

commit 52cac09d3d0b8dcdbc8d68a0bcc8092008220309
Author: Marcin Juszkiewicz <email address hidden>
Date: Mon Oct 14 04:36:48 2019 -0700

    handle push error properly

    If there was some error during pushing then Kolla was greeting with "all went
    fine" message anyway:

    INFO:kolla.common.utils.aodh-api:Trying to push the image
    ERROR:kolla.common.utils.aodh-api:Get http://10.101.16.1:5000/v2/: dial tcp 10.101.16.1:5000: connect: no route to host
    INFO:kolla.common.utils.aodh-api:Pushed successfully

    This patch changes that. Now if there is an error during push then proper
    exception is raised to PushTask and image is marked with PUSH_ERROR status.

    This way at the end of build it is easy to spot which images did not got
    pushed to registry:

    INFO:kolla.common.utils:===========================
    INFO:kolla.common.utils:Images that failed to build
    INFO:kolla.common.utils:===========================
    ERROR:kolla.common.utils:base Failed with status: push_error
    ERROR:kolla.common.utils:nova-api Failed with status: push_error
    ERROR:kolla.common.utils:nova-base Failed with status: push_error
    ERROR:kolla.common.utils:nova-compute Failed with status: push_error
    ERROR:kolla.common.utils:nova-compute-ironic Failed with status: push_error
    ERROR:kolla.common.utils:nova-conductor Failed with status: push_error

    Closes-Bug: #1848019
    Change-Id: Id2ab97bf4c0dc3423268a0ea435b56f4a65f7196