Pushing to registy ignores errors
Bug #1848019 reported by
Marcin Juszkiewicz
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
kolla |
Fix Released
|
Medium
|
Unassigned | ||
Queens |
New
|
Medium
|
Unassigned | ||
Rocky |
Fix Committed
|
Medium
|
Radosław Piliszek | ||
Stein |
Fix Committed
|
Medium
|
Radosław Piliszek | ||
Train |
Fix Released
|
Medium
|
Unassigned |
Bug Description
If pushing to registry is enabled then Kolla ignores errors and assumes that everything went fine:
INFO:kolla.
ERROR:kolla.
INFO:kolla.
Easiest way to test is adding " --push --registry any.address.
Changed in kolla: | |
assignee: | nobody → Marcin Juszkiewicz (hrw) |
status: | New → In Progress |
To post a comment you must log in.
Reviewed: https:/ /review. opendev. org/688390 /git.openstack. org/cgit/ openstack/ kolla/commit/ ?id=52cac09d3d0 b8dcdbc8d68a0bc c8092008220309
Committed: https:/
Submitter: Zuul
Branch: master
commit 52cac09d3d0b8dc dbc8d68a0bcc809 2008220309
Author: Marcin Juszkiewicz <email address hidden>
Date: Mon Oct 14 04:36:48 2019 -0700
handle push error properly
If there was some error during pushing then Kolla was greeting with "all went
fine" message anyway:
INFO: kolla.common. utils.aodh- api:Trying to push the image kolla.common. utils.aodh- api:Get http:// 10.101. 16.1:5000/ v2/: dial tcp 10.101.16.1:5000: connect: no route to host kolla.common. utils.aodh- api:Pushed successfully
ERROR:
INFO:
This patch changes that. Now if there is an error during push then proper
exception is raised to PushTask and image is marked with PUSH_ERROR status.
This way at the end of build it is easy to spot which images did not got
pushed to registry:
INFO: kolla.common. utils:= ======= ======= ======= ===== kolla.common. utils:Images that failed to build kolla.common. utils:= ======= ======= ======= ===== kolla.common. utils:base Failed with status: push_error kolla.common. utils:nova- api Failed with status: push_error kolla.common. utils:nova- base Failed with status: push_error kolla.common. utils:nova- compute Failed with status: push_error kolla.common. utils:nova- compute- ironic Failed with status: push_error kolla.common. utils:nova- conductor Failed with status: push_error
INFO:
INFO:
ERROR:
ERROR:
ERROR:
ERROR:
ERROR:
ERROR:
Closes-Bug: #1848019 423268a0ea435b5 6f4a65f7196
Change-Id: Id2ab97bf4c0dc3