Comment 5 for bug 1824587

Revision history for this message
John Beard (john-j-beard) wrote : Re: [Bug 1824587] Re: Debug spew in BOARD_CONNECTED_ITEM

If this is valid debug that alerts to a likely-wrong situation, perhaps wxLogDebug is better? Otherwise the mistake won't be visible until someone turns that particular trace on for some other reason?

On 14 April 2019 19:27:29 BST, KiCad Janitor <email address hidden> wrote:
>Fixed in revision 1d2db311b2e364caddc2f56f6525eb7bcaf4b3bf
>https://git.launchpad.net/kicad/patch/?id=1d2db311b2e364caddc2f56f6525eb7bcaf4b3bf
>
>** Changed in: kicad
> Status: In Progress => Fix Committed
>
>--
>You received this bug notification because you are subscribed to the
>bug
>report.
>https://bugs.launchpad.net/bugs/1824587
>
>Title:
> Debug spew in BOARD_CONNECTED_ITEM
>
>Status in KiCad:
> Fix Committed
>
>Bug description:
> When placing a component with the "O" tool in pcbnew, in a Debug
> build, a lot of DBG spew is produced when the as-yet-unplaced
> component is moved around:
>
> * board_connected_item.cpp 97:
> DBG(printf( "%s: NULL netclass,type %d", __func__, Type() );)
> * board_connected_item.cpp 115:
> DBG(printf( "%s: NULL board,type %d", __func__, Type() );)
>
> I assume these warnings are spurious, as it doesn't seem to be causing
> issues. However, spamming the console with strings (especially ones
> without \n!) is pretty annoying - hundreds of copies of:
>
> GetNetClass: NULL board,type 4GetClearance: NULL netclass,type
> 4GetNetClass: NULL board,type 4GetClearance: NULL netclass,type
> 4GetNetClass: NULL board,type 4GetClearance: NULL netclass,type
> 4GetNetClass: NULL board,type 4GetClearance: NULL netclass,type
> 4GetNetClass: NULL board,type 4
>
> Can we just remove the debug and keep the behaviour, or should we be
> guarding this at a higher level? They've been there since 2014, so
> this probably affects 5.1 as well (but I don't have a Debug build of
> that ATM)
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/kicad/+bug/1824587/+subscriptions