Debug spew in BOARD_CONNECTED_ITEM
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
KiCad |
Fix Released
|
Low
|
Jon Evans |
Bug Description
When placing a component with the "O" tool in pcbnew, in a Debug build, a lot of DBG spew is produced when the as-yet-unplaced component is moved around:
* board_connected
DBG(printf( "%s: NULL netclass,type %d", __func__, Type() );)
* board_connected
DBG(printf( "%s: NULL board,type %d", __func__, Type() );)
I assume these warnings are spurious, as it doesn't seem to be causing issues. However, spamming the console with strings (especially ones without \n!) is pretty annoying - hundreds of copies of:
GetNetClass: NULL board,type 4GetClearance: NULL netclass,type 4GetNetClass: NULL board,type 4GetClearance: NULL netclass,type 4GetNetClass: NULL board,type 4GetClearance: NULL netclass,type 4GetNetClass: NULL board,type 4GetClearance: NULL netclass,type 4GetNetClass: NULL board,type 4
Can we just remove the debug and keep the behaviour, or should we be guarding this at a higher level? They've been there since 2014, so this probably affects 5.1 as well (but I don't have a Debug build of that ATM)
Changed in kicad: | |
assignee: | nobody → Jon Evans (craftyjon) |
importance: | Undecided → Low |
status: | New → Triaged |
Changed in kicad: | |
status: | Triaged → In Progress |
Changed in kicad: | |
status: | Fix Committed → Fix Released |
Changed in kicad: | |
status: | Fix Committed → Fix Released |
Hmm... Maybe we should address the root here.
When placing with the option "Show Pad Clearance" on, we seem to be trying to draw the component clearance. But since the component isn't placed, we don't have the board reference.
The warnings should stay (maybe with better formatting) I think but we should turn off the references that are requesting clearance until the the component is placed.