Raytracing 3d redraw requires zoom

[David Pearce]

5.1.0 on Windows 10 64 bit
View a board 3D in Raytracing mode
Rotate the board, the view goes blocky and does not redraw.
Zoom in or out and the view redraws correctly

Application: kicad
Version: (5.1.0)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Mario Luzeiro (mrluzeiro)]

Could be possible to test this on an older revision?
I was looking for possible related changes,
may something was changes on this commit:
https://github.com/KiCad/kicad-source-mirror/commit/75f18cfe62d84be0a2f997b5f61274f15a3c6170#diff-264f5481673122f43f3c6c0c2641ae50

[David Pearce (halzia)]

I don't think it's that one, the rotation works fine in OpenGL mode.
There does not seem to be any problem detecting the selection of raytracing.
The bug is in the detection of change, the screen is redrawn showing the rotation but does not trigger a retracing

[David Pearce (halzia)]

I can reproduce the same behaviour on Ubuntu 18.04 with 5.1.0 from the PPA

[Wayne Stambaugh (stambaughw)]

It looks like it has something to do with the delayed refresh code added to prevent the view from be rendered every time a change to the board was made. I even found and interesting effect where the view would toggle between the previous rotation and the new rotation during the ray tracing so there is definitely some kind of state issue at play here.

[David Pearce (halzia)]

Tracing when you are rotating the board would be very annoying if it blocked actions, as it takes about 30 seconds to render on a fairly fast machine.

My suggestion is that tracing should only start 1 second after the last view change.

[Seth Hillbrand (sethh)]

Fix committed in 89d2e67e45

https://git.launchpad.net/kicad/commit/?id=89d2e67e4571200b3472936a279224dc1aa35da7