Comment 7 for bug 1782382

I was going to make the SetInitialFocus stuff OSX-specific, but I like your idea better.

> On 18 Jul 2018, at 20:28, Wayne Stambaugh <email address hidden> wrote:
>
> Maybe the selection should be handled in a set focus event for the text
> control. AFAIK, TransferDataToWindow is only called when the dialog is
> initialized. Moving the selection code into a set focus event would
> work anytime the control receives that focus such as tabbing through the
> controls.
>
> On 7/18/2018 3:03 PM, Jeff Young wrote:
>> So it looks like it’s platform-specific to anything-but-OSX.
>>
>> In 5.1 we delay setting the initial focus until after the dialog is
>> displayed (because OSX refuses to SetFocus to a non-visible window).
>> However, this delay puts the SetFocus call after TransferDataToWindow,
>> where the selection is set to the ‘?’. On OSX setting the focus doesn’t
>> change the selection, but I’m guessing that on Win and Linux it does.
>>
>>
>>> On 18 Jul 2018, at 19:43, Wayne Stambaugh <email address hidden> wrote:
>>>
>>> The guilty commit is 06bf958bf1953220f813d9f8f22e0fe42e11818c.
>>>
>>> --
>>> You received this bug notification because you are a member of KiCad Bug
>>> Squad, which is subscribed to KiCad.
>>> https://bugs.launchpad.net/bugs/1782382
>>>
>>> Title:
>>> Edit Reference Highlight Has Changed
>>>
>>> Status in KiCad:
>>> Triaged
>>>
>>> Bug description:
>>> Hitting E, over the reference field in Eeschema has changed.
>>> Now, hole reference text is highlighted. <R?>
>>> Previously only the question mark was highlighted like R<?>.
>>>
>>> previews highlight option was faster since it is only necessary to hit
>>> E and type the new value.
>>>
>>> Can this be a bug or a new feature?
>>> If it is a new feature it is not as good as the previews way.
>>>
>>> Using
>>> Version: 6.0.0-rc1-unknown-879ffa4~65~ubuntu18.04.1, release build
>>>
>>> To manage notifications about this bug go to:
>>> https://bugs.launchpad.net/kicad/+bug/1782382/+subscriptions
>>
>>
>> ** Changed in: kicad
>> Assignee: (unassigned) => Jeff Young (jeyjey)
>>
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1782382
>
> Title:
> Edit Reference Highlight Has Changed
>
> Status in KiCad:
> Triaged
>
> Bug description:
> Hitting E, over the reference field in Eeschema has changed.
> Now, hole reference text is highlighted. <R?>
> Previously only the question mark was highlighted like R<?>.
>
> previews highlight option was faster since it is only necessary to hit
> E and type the new value.
>
> Can this be a bug or a new feature?
> If it is a new feature it is not as good as the previews way.
>
> Using
> Version: 6.0.0-rc1-unknown-879ffa4~65~ubuntu18.04.1, release build
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1782382/+subscriptions