KiCad

Bug #1754667
Comment #13

Comment 13 for bug 1754667

Revision history for this message

Wayne Stambaugh (stambaughw) wrote on 2018-03-20: Re: [Bug 1754667] Re: pcbnew: Option Auto delete old track always delete old tracks

#13

Hey Jeff,

I made some changes in CvPcb that just refreshes the the toolbars and
menus when the canvas is changed so that only the buttons and menu
entries available in the current canvas are displayed. I think this is
easier for user to digest. Leaving a button that does nothing in the
current canvas is confusing. Even worse, showing a dialog that states
that this option isn't available in the current canvas.

Cheers,

Wayne

On 3/19/2018 11:40 AM, Jeff Young wrote:
> Hi Wayne,
>
> Yeah, we get a lot of bug reports that it doesn’t work (because it
> controls a legacy-only feature — the corresponding GAL feature is in the
> Routing Options dialog).
>
> The plan discussed in the bug report was to move it to the dialog, but
> when implementing I discovered it was already there, so I just removed
> the toolbar button.
>
> Cheers,
> Jeff.
>
>> On 19 Mar 2018, at 14:11, Wayne Stambaugh <email address hidden> wrote:
>>
>> @Jeff, I was looking over this patch and I noticed you removed the
>> toolbar option for this setting. Was there something wrong with this
>> tool bar button? I'm just wondering if users will complain about it not
>> being in the toolbar.
>>
>> --
>> You received this bug notification because you are a bug assignee.
>> https://bugs.launchpad.net/bugs/1754667
>>
>> Title:
>> pcbnew: Option Auto delete old track always delete old tracks
>>
>> Status in KiCad:
>> Fix Committed
>>
>> Bug description:
>> GAL is affected.
>> Legacy - OK.
>>
>> Application: kicad
>> Version: 5.0.0-rc2-dev-unknown-0bdae22~62~ubuntu17.10.1, release build
>> Libraries:
>> wxWidgets 3.0.3
>> libcurl/7.55.1 OpenSSL/1.0.2g zlib/1.2.11 libidn2/2.0.2 libpsl/0.18.0 (+libidn2/2.0.2) librtmp/2.3
>> Platform: Linux 4.13.0-36-generic x86_64, 64 bit, Little endian, wxGTK
>> Build Info:
>> wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
>> Boost: 1.62.0
>> Curl: 7.55.1
>> Compiler: GCC 7.2.0 with C++ ABI 1011
>>
>> Build settings:
>> USE_WX_GRAPHICS_CONTEXT=OFF
>> USE_WX_OVERLAY=OFF
>> KICAD_SCRIPTING=ON
>> KICAD_SCRIPTING_MODULES=ON
>> KICAD_SCRIPTING_WXPYTHON=ON
>> KICAD_SCRIPTING_ACTION_MENU=ON
>> BUILD_GITHUB_PLUGIN=ON
>> KICAD_USE_OCE=ON
>> KICAD_SPICE=ON
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/kicad/+bug/1754667/+subscriptions
>

Hey Jeff,

I made some changes in CvPcb that just refreshes the the toolbars and
menus when the canvas is changed so that only the buttons and menu
entries available in the current canvas are displayed.  I think this is
easier for user to digest.  Leaving a button that does nothing in the
current canvas is confusing.  Even worse, showing a dialog that states
that this option isn't available in the current canvas.

Cheers,

Wayne

On 3/19/2018 11:40 AM, Jeff Young wrote:
> Hi Wayne,
> 
> Yeah, we get a lot of bug reports that it doesn’t work (because it
> controls a legacy-only feature — the corresponding GAL feature is in the
> Routing Options dialog).
> 
> The plan discussed in the bug report was to move it to the dialog, but
> when implementing I discovered it was already there, so I just removed
> the toolbar button.
> 
> Cheers,
> Jeff.
> 
>> On 19 Mar 2018, at 14:11, Wayne Stambaugh <1754667@bugs.launchpad.net> wrote:
>>
>> @Jeff, I was looking over this patch and I noticed you removed the
>> toolbar option for this setting.  Was there something wrong with this
>> tool bar button?  I'm just wondering if users will complain about it not
>> being in the toolbar.
>>
>> -- 
>> You received this bug notification because you are a bug assignee.
>> https://bugs.launchpad.net/bugs/1754667
>>
>> Title:
>>  pcbnew: Option Auto delete old track always delete old tracks
>>
>> Status in KiCad:
>>  Fix Committed
>>
>> Bug description:
>>  GAL is affected.
>>  Legacy - OK.
>>
>>  Application: kicad
>>  Version: 5.0.0-rc2-dev-unknown-0bdae22~62~ubuntu17.10.1, release build
>>  Libraries:
>>      wxWidgets 3.0.3
>>      libcurl/7.55.1 OpenSSL/1.0.2g zlib/1.2.11 libidn2/2.0.2 libpsl/0.18.0 (+libidn2/2.0.2) librtmp/2.3
>>  Platform: Linux 4.13.0-36-generic x86_64, 64 bit, Little endian, wxGTK
>>  Build Info:
>>      wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
>>      Boost: 1.62.0
>>      Curl: 7.55.1
>>      Compiler: GCC 7.2.0 with C++ ABI 1011
>>
>>  Build settings:
>>      USE_WX_GRAPHICS_CONTEXT=OFF
>>      USE_WX_OVERLAY=OFF
>>      KICAD_SCRIPTING=ON
>>      KICAD_SCRIPTING_MODULES=ON
>>      KICAD_SCRIPTING_WXPYTHON=ON
>>      KICAD_SCRIPTING_ACTION_MENU=ON
>>      BUILD_GITHUB_PLUGIN=ON
>>      KICAD_USE_OCE=ON
>>      KICAD_SPICE=ON
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/kicad/+bug/1754667/+subscriptions
>