pcbnew: Option Auto delete old track always delete old tracks

[Eldar Khayrullin]

GAL is affected.
Legacy - OK.

Application: kicad
Version: 5.0.0-rc2-dev-unknown-0bdae22~62~ubuntu17.10.1, release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.55.1 OpenSSL/1.0.2g zlib/1.2.11 libidn2/2.0.2 libpsl/0.18.0 (+libidn2/2.0.2) librtmp/2.3
Platform: Linux 4.13.0-36-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    Curl: 7.55.1
    Compiler: GCC 7.2.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[Maciej Suminski (orsonmmz)]

Would you elaborate? What is the expected and the actual behavior?

[Eldar Khayrullin (eldar)]

GAL. See route of SETUP track

[Eldar Khayrullin (eldar)]

The expected behaviour (Legacy canvas)

[Tomasz Wlostowski (twlostow)]

In GAL, this is controlled by 'remove redundant track' option. The option "Auto delete old track" applies only to the legacy canvas. It will be removed with the legacy canvas - we need to consolidate all the routing options in a single place, that is the 'routing settings' dialog.

[Jeff Young (jeyjey)]

There's a "Legacy Routing Options" section in the Preferences dialog.

Should we remove the icon from the toolbar for 5.0, and put a checkbox in Preferences?

[Eldar Khayrullin (eldar)]

I agree with Jeff suggestion.

[Jeff Young (jeyjey)]

This has been reported 3 different times already, so I'm going to patch up the UI.

[Jeff Young (jeyjey)]

Ha, it was already in the Preferences dialog, just under the backwards name of "Delete unconnected tracks" (when what it actually does is delete *doubly* connected tracks).

[KiCad Janitor (kicad-janitor)]

Fixed in revision c6ef0d57f118758bac8cf2b530a96fb65f0baf5f
https://git.launchpad.net/kicad/patch/?id=c6ef0d57f118758bac8cf2b530a96fb65f0baf5f

[Wayne Stambaugh (stambaughw)]

@Jeff, I was looking over this patch and I noticed you removed the toolbar option for this setting. Was there something wrong with this tool bar button? I'm just wondering if users will complain about it not being in the toolbar.

[Jeff Young (jeyjey)]

Hi Wayne,

Yeah, we get a lot of bug reports that it doesn’t work (because it controls a legacy-only feature — the corresponding GAL feature is in the Routing Options dialog).

The plan discussed in the bug report was to move it to the dialog, but when implementing I discovered it was already there, so I just removed the toolbar button.

Cheers,
Jeff.

> On 19 Mar 2018, at 14:11, Wayne Stambaugh <email address hidden> wrote:
>
> @Jeff, I was looking over this patch and I noticed you removed the
> toolbar option for this setting. Was there something wrong with this
> tool bar button? I'm just wondering if users will complain about it not
> being in the toolbar.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1754667
>
> Title:
> pcbnew: Option Auto delete old track always delete old tracks
>
> Status in KiCad:
> Fix Committed
>
> Bug description:
> GAL is affected.
> Legacy - OK.
>
> Application: kicad
> Version: 5.0.0-rc2-dev-unknown-0bdae22~62~ubuntu17.10.1, release build
> Libraries:
> wxWidgets 3.0.3
> libcurl/7.55.1 OpenSSL/1.0.2g zlib/1.2.11 libidn2/2.0.2 libpsl/0.18.0 (+libidn2/2.0.2) librtmp/2.3
> Platform: Linux 4.13.0-36-generic x86_64, 64 bit, Little endian, wxGTK
> Build Info:
> wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
> Boost: 1.62.0
> Curl: 7.55.1
> Compiler: GCC 7.2.0 with C++ ABI 1011
>
> Build settings:
> USE_WX_GRAPHICS_CONTEXT=OFF
> USE_WX_OVERLAY=OFF
> KICAD_SCRIPTING=ON
> KICAD_SCRIPTING_MODULES=ON
> KICAD_SCRIPTING_WXPYTHON=ON
> KICAD_SCRIPTING_ACTION_MENU=ON
> BUILD_GITHUB_PLUGIN=ON
> KICAD_USE_OCE=ON
> KICAD_SPICE=ON
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1754667/+subscriptions

[Wayne Stambaugh (stambaughw)]

Hey Jeff,

I made some changes in CvPcb that just refreshes the the toolbars and
menus when the canvas is changed so that only the buttons and menu
entries available in the current canvas are displayed. I think this is
easier for user to digest. Leaving a button that does nothing in the
current canvas is confusing. Even worse, showing a dialog that states
that this option isn't available in the current canvas.

Cheers,

Wayne

On 3/19/2018 11:40 AM, Jeff Young wrote:
> Hi Wayne,
>
> Yeah, we get a lot of bug reports that it doesn’t work (because it
> controls a legacy-only feature — the corresponding GAL feature is in the
> Routing Options dialog).
>
> The plan discussed in the bug report was to move it to the dialog, but
> when implementing I discovered it was already there, so I just removed
> the toolbar button.
>
> Cheers,
> Jeff.
>
>> On 19 Mar 2018, at 14:11, Wayne Stambaugh <email address hidden> wrote:
>>
>> @Jeff, I was looking over this patch and I noticed you removed the
>> toolbar option for this setting. Was there something wrong with this
>> tool bar button? I'm just wondering if users will complain about it not
>> being in the toolbar.
>>
>> --
>> You received this bug notification because you are a bug assignee.
>> https://bugs.launchpad.net/bugs/1754667
>>
>> Title:
>> pcbnew: Option Auto delete old track always delete old tracks
>>
>> Status in KiCad:
>> Fix Committed
>>
>> Bug description:
>> GAL is affected.
>> Legacy - OK.
>>
>> Application: kicad
>> Version: 5.0.0-rc2-dev-unknown-0bdae22~62~ubuntu17.10.1, release build
>> Libraries:
>> wxWidgets 3.0.3
>> libcurl/7.55.1 OpenSSL/1.0.2g zlib/1.2.11 libidn2/2.0.2 libpsl/0.18.0 (+libidn2/2.0.2) librtmp/2.3
>> Platform: Linux 4.13.0-36-generic x86_64, 64 bit, Little endian, wxGTK
>> Build Info:
>> wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
>> Boost: 1.62.0
>> Curl: 7.55.1
>> Compiler: GCC 7.2.0 with C++ ABI 1011
>>
>> Build settings:
>> USE_WX_GRAPHICS_CONTEXT=OFF
>> USE_WX_OVERLAY=OFF
>> KICAD_SCRIPTING=ON
>> KICAD_SCRIPTING_MODULES=ON
>> KICAD_SCRIPTING_WXPYTHON=ON
>> KICAD_SCRIPTING_ACTION_MENU=ON
>> BUILD_GITHUB_PLUGIN=ON
>> KICAD_USE_OCE=ON
>> KICAD_SPICE=ON
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/kicad/+bug/1754667/+subscriptions
>

[Jeff Young (jeyjey)]

@Wayne, I assume you mean Pcbnew, not CvPcb?

Anyway, did you hook into ShowChangedLanguage()? That's probably the easiest way to trigger them getting rebuilt.

[Wayne Stambaugh (stambaughw)]

@Jeff

On 3/20/2018 9:38 AM, Jeff Young wrote:
> @Wayne, I assume you mean Pcbnew, not CvPcb?

I meant CvPcb. The changes I made there are similar in concept.

>
> Anyway, did you hook into ShowChangedLanguage()? That's probably the
> easiest way to trigger them getting rebuilt.
>

There was already a hook in CvPcb that used when the canvas changes so I
used that. We should probably unify this as some point in the future if
this is happening multiple places.

[l3iggs (l3iggs)]

I'm seeing this bug today. Should I expect the fix posted here to be in 5.1.2?