Newer versions of kombu rely on updated versions of amqp [0]. Keystone's
lower-constraints job is failing consistently across multiple branches
because it's referencing amqp 2.2.2 when we should be relying on a newer
version (5.0.0+).
You can verify this by using `pip3 check` with the lower-constraints tox
environment.
Without this patch, you'll likely see the test_notifications tests fail
with something like:
ModuleNotFoundError: No module named 'vine.five'
Which spirals into subsequent failures mocking messaging drivers.
This commit also fixes the lower-constraint for PyMySQL.
keystone does not have any lower constraint for PyMySQL so the
latest version 0.10.0 is picked by the job which is failing [1]
In OpenStack, PyMySQL's upper constraint is 0.9.3. Version 0.10.0 is
not tested [2]. Let's add PyMySQL lower constraint also so that we test
lower-constraint job with correct lower version.
Both of these fixes were proposed separate reviews in newer branches,
but due to a circular failure, they're being proposed together. The
amqp fix fails lower-constraints jobs because the PyMySQL issue and vice
versa.
Reviewed: https:/ /review. opendev. org/748474 /git.openstack. org/cgit/ openstack/ keystone/ commit/ ?id=56c95ce7859 8aee306b8fcdb72 0bbbdd8efc040f
Committed: https:/
Submitter: Zuul
Branch: stable/stein
commit 56c95ce78598aee 306b8fcdb720bbb dd8efc040f
Author: Lance Bragstad <email address hidden>
Date: Wed Sep 9 13:48:30 2020 -0500
Update amqp and PyMySQL lower constraints
Newer versions of kombu rely on updated versions of amqp [0]. Keystone's constraints job is failing consistently across multiple branches
lower-
because it's referencing amqp 2.2.2 when we should be relying on a newer
version (5.0.0+).
You can verify this by using `pip3 check` with the lower-constraints tox
environment.
Without this patch, you'll likely see the test_notifications tests fail
with something like:
ModuleNot FoundError: No module named 'vine.five'
Which spirals into subsequent failures mocking messaging drivers.
This commit also fixes the lower-constraint for PyMySQL.
keystone does not have any lower constraint for PyMySQL so the constraint job with correct lower version.
latest version 0.10.0 is picked by the job which is failing [1]
In OpenStack, PyMySQL's upper constraint is 0.9.3. Version 0.10.0 is
not tested [2]. Let's add PyMySQL lower constraint also so that we test
lower-
Both of these fixes were proposed separate reviews in newer branches,
but due to a circular failure, they're being proposed together. The
amqp fix fails lower-constraints jobs because the PyMySQL issue and vice
versa.
[0] https:/ /github. com/celery/ celery/ issues/ 3547 /zuul.opendev. org/t/openstack /build/ 3077d96f4fff4b7 985cb763d0635d4 71/log/ job-output. txt#621 /github. com/openstack/ requirements/ blob/master/ upper-constrain ts.txt# L384
[1]https:/
[2]https:/
Change-Id: I3834b3b34641c0 06c70614d5331d2 92c41f8a346 f5a38d2a9e4d5aa c5653fb406) 7ba22884cf78ad7 d1faa8569d) 0ce54889ae5f782 fbac4a9a2e) ce8112cef0b8636 1c34d9993b) b0d0d25cb468250 cf34804eaf) 988ec92a74bf9b4 9b71d77d1b) 46a5136ca4028f4 e128b947c2) 0934ab123eb10f3 3df7f581c5)
Closes-Bug: #1888886
(cherry picked from commit c495defc2bd4f2e
(cherry picked from commit 12891a039fb1dae
(cherry picked from commit b7c3458b6f11ade
(cherry picked from commit 255b6cdd70db654
(cherry picked from commit 3de085b1eb9750c
(cherry picked from commit 300e79e93b9966e
(cherry picked from commit fb7d54543fd69e0
(cherry picked from commit 32967a8105efd2a