Comment 3 for bug 1542506

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to ironic (master)

Reviewed: https://review.openstack.org/269311
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=22ea3fb3b72b614bb1a052a04b5cf5a5359b5b40
Submitter: Zuul
Branch: master

commit 22ea3fb3b72b614bb1a052a04b5cf5a5359b5b40
Author: Jim Rollenhagen <email address hidden>
Date: Mon Jan 18 14:24:29 2016 -0800

    Fail deploy if agent returns >= 400

    Currently the status code returned by IPA's POST /v1/commands API is
    completely ignored by Ironic. This causes deploys to get stuck, as
    future heartbeats will see that the command has not yet been accepted
    and will continue to wait.

    If IPA returns an error code to Ironic's agent client, we should bubble
    that exception up, causing a deploy failure higher in the chain.

    This adds an AgentAPIError exception class, and raises it when the agent
    returns a 400 status code or higher when issuing a command.

    Co-Authored-By: Jay Faulkner <email address hidden>

    Related-bug: 1542506
    Change-Id: I07fb8115d254e877d8781207eaec203e3fdf8ad6