Handle IronicExceptions raised by agent_client

[Ruby Loo]

We don't seem to be handling any IronicExceptions raised by agent_client.AgentClient._command() [1], eg deploy_utils.agent_get_clean_steps() [2].

This was pointed out by Vasyl [3].

[1] https://github.com/openstack/ironic/blob/0812dcaba04baa59e65d6d95b992cc265e8992d3/ironic/drivers/modules/agent_client.py#L86
[2] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L571
[3] https://review.openstack.org/#/c/247695/15/ironic/drivers/modules/agent_base_vendor.py

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/290131

[Dmitry Tantsur (divius)]

Hi Ruby. This bug is too broad and I'm closing it. Please provide specific places where handing IronicException is *required*. E.g. what https://review.openstack.org/290131 is currently doing is just incorrect.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/269311
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=22ea3fb3b72b614bb1a052a04b5cf5a5359b5b40
Submitter: Zuul
Branch: master

commit 22ea3fb3b72b614bb1a052a04b5cf5a5359b5b40
Author: Jim Rollenhagen <email address hidden>
Date: Mon Jan 18 14:24:29 2016 -0800

    Fail deploy if agent returns >= 400

    Currently the status code returned by IPA's POST /v1/commands API is
    completely ignored by Ironic. This causes deploys to get stuck, as
    future heartbeats will see that the command has not yet been accepted
    and will continue to wait.

    If IPA returns an error code to Ironic's agent client, we should bubble
    that exception up, causing a deploy failure higher in the chain.

    This adds an AgentAPIError exception class, and raises it when the agent
    returns a 400 status code or higher when issuing a command.

    Co-Authored-By: Jay Faulkner <email address hidden>

    Related-bug: 1542506
    Change-Id: I07fb8115d254e877d8781207eaec203e3fdf8ad6

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/521649

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/521649
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=a7ef398337f90db4e60bbfb1c97c429e6669794e
Submitter: Zuul
Branch: master

commit a7ef398337f90db4e60bbfb1c97c429e6669794e
Author: Ruby Loo <email address hidden>
Date: Mon Nov 20 15:14:30 2017 -0500

    Followup to I07fb8115d254e877d8781207eaec203e3fdf8ad6

    This adds punctuation to a log string and clarifies an
    exception string.

    Change-Id: Ifde1ebbc8457d33e8d063bf1dbb9b5fbf14857ea
    Related-bug: 1542506