Keyboard shortcuts not appearing in the main menu under Unity

Bug #998276 reported by John Smith on 2012-05-11
38
This bug affects 8 people
Affects Status Importance Assigned to Milestone
AppMenu GTK+
New
Undecided
Unassigned
Inkscape
Medium
John Smith
inkscape (Ubuntu)
Low
Unassigned

Bug Description

Main menu does not show the keyboard shortcut associated with each menu item under Ubuntu 12.10 (Unity).

Seems to work fine under Windows, OSX and Debain/Gnome.
Other applications under Unity are also not affected.

John Smith (john-smithi) on 2012-05-11
Changed in inkscape:
assignee: nobody → John Smith (john-smithi)
su_v (suv-lp) on 2012-05-24
tags: added: shortcuts
su_v (suv-lp) wrote :

Probably related to
Bug #775702 "Some menu icons missing in Inkscape since upgrade to 11.04"
<https://bugs.launchpad.net/bugs/775702>

On screenshots provided by Ubuntu (Unity) users affected by the missing menu icons, the keyboard shortcuts are also missing.

Alex Valavanis (valavanisalex) wrote :

Confirmed with lp:inkscape r11404 on Ubuntu 12.04 amd64

Changed in inkscape (Ubuntu):
importance: Undecided → Low
status: New → Triaged
su_v (suv-lp) wrote :

Alex Valavanis wrote
> Confirmed with lp:inkscape r11404 on Ubuntu 12.04 amd64

Could you test/confirm that the keyboard shorctcuts (as well as the menu icons loaded from Inkscape's icons.svg file) are present on Ubuntu using the "workarounds" mentioned in bug #775702:
- using the Gnome desktop instead of Unity
  <https://bugs.launchpad.net/ubuntu/+source/inkscape/+bug/775702/comments/12>
- without the global menu (appmenu-gtk)
  <https://bugs.launchpad.net/ubuntu/+source/inkscape/+bug/775702/comments/16>
- running inkscape as root
  <https://bugs.launchpad.net/ubuntu/+source/inkscape/+bug/775702/comments/22>

Dimitrijj (d-pulim) wrote :

I have this problem too.
- If I run Inkscape as user the keyboard shortcuts aren't display in the Inkscape's global menu under Unity.

- If I run Inkscape with sudo it doesn't use global menu. The Inkscape's main menu is place in the Inkscape's window. The keyboard shortcuts are display in this menu.

I don't have Gnome desktop installed.

Ubuntu 12.04 i386

John Smith (john-smithi) on 2012-09-04
Changed in inkscape:
assignee: John Smith (john-smithi) → nobody
su_v (suv-lp) wrote :

Reproduced on Ubuntu 12.10 with current trunk.

Not reproduced (shortcuts are displayed for menu items which have one) when launching Inkscape in a sub-shell without global menu integration, e.g. like this:
$ (unset UBUNTU_MENUPROXY; inkscape)

Setting bug status to 'Confirmed' for now - IMHO it looks more like a GTK+ and/or appmenu problem though.

Changed in inkscape:
importance: Undecided → Medium
status: New → Confirmed
su_v (suv-lp) wrote :

<off-topic>
> launching Inkscape in a sub-shell without global menu integration, e.g. like this:
> $ (unset UBUNTU_MENUPROXY; inkscape)

Alternatively one could define an alias (in ~/.bash_aliases):
inkscape="UBUNTU_MENUPROXY= inkscape"

For additional tips how to disable the global menu per application, see e.g.
<http://askubuntu.com/questions/6784/is-it-possible-to-make-indicator-appmenu-ignore-a-specific-application>
</off-topic>

John Smith (john-smithi) on 2013-01-21
Changed in inkscape:
assignee: nobody → John Smith (john-smithi)
status: Confirmed → In Progress
John Smith (john-smithi) wrote :

Patch that should show the keyboard shortcuts (accelerators) in the main menu under Ubuntu Unity.
Replaces the Inkscape custom labels with standard gtk menu accelerators.

Tested on Windows 7 and Ubuntu 12.10.
Would like to see if it works under OS X.

The attachment "998276.v1.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
tags: added: patch-forwarded-upstream
removed: patch
su_v (suv-lp) wrote :

> Would like to see if it works under OS X.

Can't test myself yet with gtk-mac-integration (no patch/branch shared for the most recent changes (RC3)), but when using the patch with normal per-window menu of current trunk (all combinations of backends and versions: X11, Quartz, GTK2, GTK3), the same issue as with the 0.48.x RC3 OS X package occurs: a conflict between the on-canvas text-editing context and menu shortcuts:
<http://thread.gmane.org/gmane.comp.graphics.inkscape.devel/39707/focus=39712>

Characters like v,h,D,G,+,-, etc. trigger keyboard shortcuts instead of being entered as characters into the current text object being edited on-canvas.

Depending on the theme used, one can also notice that the affected keyboard shortcuts (accelerators) in the menu entries are differently colored than the rest (they use the same foreground colours as the menu item labels, whereas those based on standard gtk menu accelerators may use a dimmer foreground color than the menu item label itself).

su_v (suv-lp) wrote :

> a conflict between the on-canvas text-editing context and menu shortcuts:

It's even more pervasive than just affecting the text-editing context: shortcuts also get triggered unexpectedly when trying to enter alphanumeric characters into spin boxes, or entry widgets, elsewhere in the GUI (e.g. the zoom presets).

ScislaC (scislac) wrote :

Same behavior observed as reported by ~suv on Ubuntu 12.10 with r12050 + the above patch. Another observation, with numlock on, just pressing 5 on the numpad alone will trigger Grayscale mode (no need to hold Ctrl).

su_v (suv-lp) wrote :

'Ctrl+C', 'Ctrl+V' are "restricted" to objects on-canvas, even if the user wants e.g. to copy&paste text somewhere in a GUI widget - e.g. a style property in the XML Editor (originally described by victor on 'inkscape-devel' about the OS X RC3 package: <http://article.gmane.org/gmane.comp.graphics.inkscape.devel/39718>).

John Smith (john-smithi) on 2013-02-02
Changed in inkscape:
status: In Progress → Confirmed
assignee: John Smith (john-smithi) → nobody
John Smith (john-smithi) wrote :

Attached v2 patch should hopefully fix the problems in comments 9 to 12.
Should be able to enter text on canvas, in spin-boxes and cut/paste in dialogs without triggering shortcuts.

Using standard gtk accelerators for menu display only and not to invoke actual shortcuts.

Changed in inkscape:
assignee: nobody → John Smith (john-smithi)
status: Confirmed → In Progress
su_v (suv-lp) wrote :

Patch tested successfully with r12119 on Ubuntu 12.10 (with global menubar), and on OS X (X11 and Quartz-based builds without menubar integration, see comment #9) - so far, no regressions encountered (only a few quick tests done for the known and mentioned issues with v1, and as known from Valerio's Quartz-based RC packages for OS X).

John Smith (john-smithi) wrote :

Committed to trunk as r12132.

Changed in inkscape:
status: In Progress → Fix Committed
su_v (suv-lp) wrote :

@John - do you happen to know whether the HTML markup currently used in strings for the menu items (taken from the definition of the verbs in 'src/verbs.cpp') needs to be adjusted to the changes in r12132?

Please see this question on the translators mailing list as reference:
<http://thread.gmane.org/gmane.comp.graphics.inkscape.translator/1309/focus=1312>

John Smith (john-smithi) wrote :

Oops my mistake, i didnt notice there was markup in the menus and didnt include the markup code.
Hopefully the attached v3 patch should revert and fix the markup issues.

jazzynico (jazzynico) wrote :

Patch tested successfully on Debian testing, Inkscape revision 12189.
Thanks John!

su_v (suv-lp) wrote :

Patch also tested successfully on OS X 10.7 with Inkscape 0.48+devel r12189
(GTK+/X11 2.24.13, GTK+/Quartz 2.24.17 (without osx menubar integration))

John Smith (john-smithi) wrote :

Thanks for testing.
Committed markup fix as r12190.

Changed in inkscape:
status: Fix Committed → Fix Released
Changed in inkscape (Ubuntu):
status: Triaged → Fix Released
Changed in inkscape:
milestone: none → 0.91
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers