Comment 5 for bug 932474

Revision history for this message
su_v (suv-lp) wrote :

> This is my first patch to Inkscape so if I have broken any
> rules or missed any steps I would love to get that feedback.

Many thanks for investigating the regression and sharing the fix: no broken rules or missed steps :-)

> The patch has been tested on Ubuntu Linux and Windows 7.

Patch tested ok with Inkscape 0.48+devel r11019 on
- Mac OS X 10.5.8 with GTK+/Quartz 2.24.10, gtkmm 2.24.2
- OS X 10.7.2 with GTK+/X11 2.24.10, gtkmm 2.24.2

(the patch in its original form did not apply for me (failed for src/ui/dialog/filter_effects_dialog.h.) but I haven't figured out why - whether it's a problem with different file encodings, line endings, or white spaces diffs. Attaching the diff against r11019 used instead).

Patch still needs review by one of the devs before getting applied (I don't code C++ myself).