The save as dialog gives wrong directory on Win32

Bug #769725 reported by David Xiong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Incomplete
Undecided
Johan Engelen

Bug Description

If a user saves a file once, and try to save as for the second time, the save file dialog should pop up the directory where the file was just saved last time. But, it pops up the one-level-up directory.

It happens in Windows Vista and Windows XP. I compiled and tested Inkscape in both Windows Vista and XP.

This bug is highly relevant to the bug: https://bugs.launchpad.net/inkscape/+bug/408566

- Create a new drawing, and draw a couple objects
- Click Save as to save the drawing into a folder "test. a"
- This reproduces the bug that I am trying to fix (https://bugs.launchpad.net/inkscape/+bug/408566)
- Click Save as again,

--> it is supposed to go into the folder, "test. a", where the last file was saved. But it actually goes to the folder that is one level up. Also, the default_filename should be "drawing", but is actually "test". This is caused by checking the ".". For instance, it may look for the "." in ".svg". However, there is a "." in "test. a" folder name, so it picked the wrong ".". Therefore, the wrong folder and wrong default_filename was picked.

This issue would be a problem if a user wants to save to "test. a" for many times. It would always show the upper directory, and need clicking to get into "test. a".

Tags: saving ui win32
Revision history for this message
David Xiong (yunwxiong) wrote :

It is fixed with the bug, https://bugs.launchpad.net/inkscape/+bug/769725, being fixed.

If the file does not miss the extension, the problem does not occur any more. It is just a quick fix. A better overal handling and cleanup on file.cpp may be needed.

Revision history for this message
Johan Engelen (johanengelen) wrote : Re: [Bug 769725] Re: The save as dialog gives wrong directory on Win32

On 24-4-2011 10:18, David Xiong wrote:
> It is fixed with the bug,
> https://bugs.launchpad.net/inkscape/+bug/769725, being fixed.

I think you wrote a wrong link there David (since it points to this bug
here :) Which bug did you mean?

Revision history for this message
su_v (suv-lp) wrote :

Status changed to 'Incomplete' -> needs clarification as to by which bug fix this issue will be handled.

tags: added: saving ui win32
Changed in inkscape:
status: New → Incomplete
Revision history for this message
su_v (suv-lp) wrote :

Probably comment #1 wanted to refer to
Bug #408566 “Program won't save files without given extension on Win32”
<https://bugs.launchpad.net/inkscape/+bug/408566>

Proposing to link as duplicate to bug #408566.

Revision history for this message
Johan Engelen (johanengelen) wrote :

Is it fixed after r10820?

Changed in inkscape:
assignee: nobody → Johan Engelen (johanengelen)
Revision history for this message
jazzynico (jazzynico) wrote :

Reproduced on Windows XP, Inkscape 10760.
Fix confirmed with Inkscape 10867 and 10922.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.