"Warn on closing with multiple tabs open" not honored

[tiggsy]

Binary package hint: firefox

1) lsb_release -rd
Description: Ubuntu 11.10
Release: 11.10

2) apt-cache policy firefox
firefox:
  Installed: 11.0+build1-0ubuntu0.11.10.1
  Candidate: 11.0+build1-0ubuntu0.11.10.1
  Version table:
 *** 11.0+build1-0ubuntu0.11.10.1 0
        500 http://us.archive.ubuntu.com/ubuntu/ oneiric-updates/main i386 Packages
        500 http://security.ubuntu.com/ubuntu/ oneiric-security/main i386 Packages
        100 /var/lib/dpkg/status
     7.0.1+build1+nobinonly-0ubuntu2 0
        500 http://us.archive.ubuntu.com/ubuntu/ oneiric/main i386 Packages

3) What is expected to happen in Firefox, with Edit -> Preferences -> Tabs -> "Warn on closing with multiple tabs open" checkbox checked, is when one click the X, File -> Quit, Ctrl+Q , or Alt+Space -> C, one get's the confirmation box:
Confirm close
You are about to close x tabs. Are you sure you want to continue?

4) What happens instead is one is not warned and the window closes.

PARTIAL WORKAROUND: about:config -> browser.tabs.maxOpenBeforeWarn -> change from 15 to 2. This will pop up the confirmation box clicking the X and Alt+Space -> C only.

WORKAROUND: Disable Ctrl+Q quiting the browser by installing keyconfig add-on:
http://mozilla.dorando.at/keyconfig.xpi

Then Tools -> Add-Ons -> Extensions -> keyconfig Preferences -> highlight Quit -> Disable

Original Reporter Comments: I found a "workaround" that says to set "open to a blank page" somewhere else, and I set this, but it still doesn't warn me.

I work from home and frequently spend an hour or so putting in data, all on one screen. If I accidentally hit the stupid little x (which is now in the left hand corner just where you don't need it, it is too easy to hit it by accident, but i can't change this, it comes with the distro), i lose all that work.

Please tell me how to fix this terrible bug.

Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.2.3) Gecko/20100423 Ubuntu/10.04 (lucid) Firefox/3.6.3 GTB7.1

THIS BUG AFFECTS MY SECURITY (INCOME) but i guess would not be classifed as a security bug per se

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: firefox 3.6.3+nobinonly-0ubuntu4
ProcVersionSignature: Ubuntu 2.6.32-22.33-generic 2.6.32.11+drm33.2
Uname: Linux 2.6.32-22-generic i686
Architecture: i386
Date: Fri May 21 14:07:40 2010
FirefoxPackages:
 firefox 3.6.3+nobinonly-0ubuntu4
 firefox-gnome-support 3.6.3+nobinonly-0ubuntu4
 firefox-branding 3.6.3+nobinonly-0ubuntu4
 abroswer N/A
 abrowser-branding N/A
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release i386 (20100429)
ProcEnviron:
 LANG=en_GB.UTF-8
 SHELL=/bin/bash
SourcePackage: firefox

[Tellrob (tellrob)]

This caused me to lose 50+ tabs today on 3.5.

Steps to reproduce:
1. Create a new profile
2. uncheck Prefs -> Tabs -> Warn me when closing multiple tabs
3. Open up some tabs.
4. Close the browser (File -> Exit)

No warning appears despite browser.warnOnQuit being true. The tabs are not saved.

[Ria-klaassen (ria-klaassen)]

Yes, both prefs should set to true. I believe it always been like this from the beginning of the Quit dialog.

[Tellrob (tellrob)]

Here's the use case for having tabs.warnOnClose set to false and browser.warnOnQuit set to true:
I have tabs.warnOnClose set to false so that I can easily close windows via the taskbar previews in windows 7 (knowing that I can get them back through "Recently Closed Windows"). I still want to be prompted when I exit the browser to save my tabs.

[Gavin Sharp (gavin-sharp)]

This behavior was a tradeoff that we made late in the 3.0 cycle, there are a bunch of bugs that go over this in more detail (bug 433018, bug 428843). There are some open bugs that cover related issues (bug 419009, bug 443396, bug 384907). I think this is a dupe of bug 419009?

I don't think that wanting to be warned when quitting but not when closing a window is that common, though now that we have undo-close-window I guess it's more logical.

[Marcus-ps+mozilla (marcus-ps+mozilla)]

I have

browser.tabs.warnOnClose = true
browser.warnOnQuit = true
browser.warnOnRestart = true

If I close a window with multiple tabs I get a warning dialog box. If I choose quit from the meny, I get no warning whatsoever. If I choose "restart Firefox" from the addon update window, I get no warning whatsoever.

If my privacy options are set to "Clear history at restart", even though I have all these options set to true, and even though I have an option stating "Start Firefox with the windows/tabs from last time", an addon/browser update, or a quit due to instability issues wipes out all my open windows and tabs with no hope of recovering them.

This really makes no sense to me, and there should be a safer way to ensure that the expectations of the developers and the users don't clash in this way causing loss of data.

[Draycen DeCator (ddecator)]

Thank you for reporting this to Ubuntu. Sometimes Firefox profiles can become corrupt and/or extensions can conflict. Could you please try this with a new profile and see if the problem still exists? You do not need to delete your old profile to test. If this helps, you might want to try to disable all your extensions and re-enable them one by one until you find the problematic one.

You can start the profile manager with the following command:
firefox -ProfileManager

Also, in regards to the button placement, the button location is theme-specific, so you can change the button layout by changing from Ambiance/Radiance to something else.

[tiggsy (frann-leach)]

Is there a way to do this without losing all my bookmarks and passwords? Cos if not, I pass, sorry.

[Launchpad Janitor (janitor)]

[Expired for firefox (Ubuntu) because there has been no activity for 60 days.]

[Avi Greenbury (bigreds)]

I see the same behaviour, also in a new profile for testing.

I get a warning on using the 'x' in the corner, but not on ctrl+q

[hazylazysusan (hazylazysusan)]

I have the same problem when using the x--doesn't show anything.

[hazylazysusan (hazylazysusan)]

I had to change this option in about:config, to "2".

browser.tabs.maxOpenBeforeWarn

I don't know why it's not set to 2 in the first place...

[hazylazysusan (hazylazysusan)]

(that fixed my problem)

[hazylazysusan (hazylazysusan)]

Update: This only seems to fix it if you click the x. If you choose File->Quit, it STILL doesn't show the dialog box.

[Pppx (pppx)]

*** Bug 676679 has been marked as a duplicate of this bug. ***

[Pppx (pppx)]

*** Bug 676677 has been marked as a duplicate of this bug. ***

[Pppx (pppx)]

*** Bug 641500 has been marked as a duplicate of this bug. ***

[Pppx (pppx)]

*** Bug 644693 has been marked as a duplicate of this bug. ***

[Pppx (pppx)]

This problem should be resolved after Bug 550559 landed

[Pppx (pppx)]

Also, current warning on quit behavior described here:
http://blog.zpao.com/post/3174360617/about-that-quit-dialog
http://hg.mozilla.org/mozilla-central/file/84921e24be9c/browser/components/nsBrowserGlue.js#l443

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[penalvch (penalvch)]

tiggsy, thank you for reporting this bug and helping make Ubuntu better. The issue you are reporting is an upstream one and it would be nice if somebody having it could send the bug to the developers of the software by following the instructions at https://developer.mozilla.org/en/Bug_writing_guidelines . If you have done so, please tell us the number of the upstream bug (or the link), so we can add a bugwatch that will inform us about its status. Thanks in advance.

[penalvch (penalvch)]

Importance Low due to easy workaround -> keyconfig.

[Ali Najafi (alinajafi)]

I found that checking the "Warn me when closing multiple tabs" in Preferences affects "browser.tabs.WarnOnClose" in about:config, instead of "browser.showQuitWarning".

[Rena Kunisaki (i-am-inuyasha)]

Still an issue with 16.0.2. Accidentally hit Ctrl+Q instead of Ctrl+W (and you will), browser just quits without any warning or prompt. Extremely annoying, extremely obvious design issue that should have been fixed over 2 years ago now.

At least in recent versions it's possible to restore the session, thus making this more of an annoyance than a fatal bug that would make the browser unusable.

[Dario Ruellan (druellan)]

Firerox 18.0.1 and Ubuntu 12.10 here:

Clicking the X button: shows confirmation dialog
Selecting quit on the launcher: shows confirmation dialog
ALT + F4: shows confirmation dialog

CTRL + Q: closes right away
Firefox menu -> quit: closes right away

Checking on Windows, Firefox behaves the same way, so, we can't be sure it is a bug or a design thing.

[Dario Ruellan (druellan)]

Seems related to upstream https://bugzilla.mozilla.org/show_bug.cgi?id=502908

[yfdyh000 (yfdyh000)]

*** Bug 1149661 has been marked as a duplicate of this bug. ***

[yfdyh000 (yfdyh000)]

*** Bug 1207811 has been marked as a duplicate of this bug. ***

[yfdyh000 (yfdyh000)]

*** Bug 1242150 has been marked as a duplicate of this bug. ***

[yfdyh000 (yfdyh000)]

*** Bug 1316842 has been marked as a duplicate of this bug. ***

[Grgoffe (grgoffe)]

Hi,

This problem just started happening to me with FF Nightly, which I update daily. Two updates ago, it was working wonderfully... now it's "adios" with NO warning.

I looked in about:config and searched on "warnon". ALL variables appeared (11 in number) have the value of "true".

Is there a way for me to load several updates previously (say 5 days ago) and test this?

THANKS!

George...

[Grgoffe (grgoffe)]

My earlier statement about when this problem started happening was in error. I have tried the "released" version and the "beta" version as well as the "nightly" versions and ALL had the same behavior. Quit without any notification. Argh!

George...

[Epinal99-bugzilla2 (epinal99-bugzilla2)]

*** Bug 1325652 has been marked as a duplicate of this bug. ***

[Bludshot (bludshot)]

The reporter reports that he got no warning after doing his step 2 "uncheck Prefs -> Tabs -> Warn me when closing multiple tabs",

I get no warning after *checking* 'Warn me when closing multiple tabs'

[yfdyh000 (yfdyh000)]

*** Bug 1350747 has been marked as a duplicate of this bug. ***

[Andre Klapper (a9016009)]

*** Bug 1350747 has been marked as a duplicate of this bug. ***

[Grgoffe (grgoffe)]

Andre,

I just checked my browser settings and see that "browserWarnOnQuit" is true but "browser.ShowQuitWarning" is false. Is that the problem here? I have NOT made any changes in quite some time.

Thanks,

George...

[Gijskruitbosch+bugs (gijskruitbosch+bugs)]

*** Bug 1365469 has been marked as a duplicate of this bug. ***

[Damian Yerrick (tepples)]

"Importance Low due to easy workaround -> keyconfig."

The Keybinder extension worked in Firefox 56 but has stopped working since Firefox 57. So I'd recommend "Importance Low" for `firefox-esr` but not "Low" for `firefox`.

[Amlee (amlee)]

I've attached a spec for Preferences when Session Restore is Enabled and Disabled. The warning will not show up by default if Session Restore is enabled but I've added a pref that allows users to turn the warning message on when Session Restore is enabled if desired.

NI Meridel to review the copy. Thanks!

[Amlee (amlee)]

Created attachment 8995330
Preferences - Close Tab Warning.png

Spec for Restore Previous Session Setting in Preferences

[Mwalkington (mwalkington)]

Prefs copy looks good and hasn't changed from what we have currently.

Edits to close warning dialogue:
-Numbers less than ten should be spelled out. So if the user is closing 2 - 9 tabs, spell out the number of tabs.
-Button copy should be capitalized
-The checkbox string should be in second person and consistent with language in Prefs

So, confirm close copy should be:

**Confirm close**
You are about to close seven tabs. Are you sure you want to continue?

Warn me when closing multiple tabs

Cancel Close Tabs

[Amlee (amlee)]

Great! Thanks Meridel. Can we reassign this bug to someone that can implement the changes? Currently this bug is assigned to me.

[Gijskruitbosch+bugs (gijskruitbosch+bugs)]

(In reply to Meridel from comment #46)
> Prefs copy looks good and hasn't changed from what we have currently.
>
> Edits to close warning dialogue:
> -Numbers less than ten should be spelled out. So if the user is closing 2 -
> 9 tabs, spell out the number of tabs.

This is really annoying to implement, and requires localizers to provide translations for all these numbers. It also makes it harder to scan for the numbers when reading the warning. It's also not clear to me that any convention in (American?) English that you're using here applies in other languages (eg I grew up in the Netherlands and the rule I got taught was to write out numbers under 20, as well as any numbers divisible by 10 (under 100) or 100 (under 1000), etc.). So it would be "five thousand tabs" but "5341 tabs". I would be unsurprised if other languages used other conventions still. It also doesn't seem related to this bug. If you feel strongly that this is necessary, can you file a separate bug for this, maybe with more details about how that should work?

For the changes to the prefs:

(In reply to Amy Lee [:amylee] UX from comment #44)
> I've attached a spec for Preferences when Session Restore is Enabled and
> Disabled. The warning will not show up by default if Session Restore is
> enabled but I've added a pref that allows users to turn the warning message
> on when Session Restore is enabled if desired.

I have a several concerns here.

First, now if users have session restore enabled there is 1 pref that governs both window closing and quitting. Unfortunately, there isn't a pref to turn on warnings for quit but not have warnings when closing multiple tabs otherwise. This would be desirable because it's easy to mis-hit cmd-q when trying to hit cmd-w (to close a tab). You have to try pretty hard to mis-hit cmd-shift-w (to close a window) or to close multiple tabs using the mouse. So I want a warning when quitting but not when closing a window, but I can't have that either today or with the implementation you're suggesting. That seems like something we should fix.

Second, users who are used to the current behavior with session restore enabled (esp. on Windows, where mis-hitting ctrl-shift-q is also not a major concern) will start getting warning dialogs when we implement the new behavior. That seems disruptive. But we can't turn off the warning everywhere because then they won't get a warning when closing a window, which they might have relied upon. Any thoughts about how to address that?

[Amlee (amlee)]

(In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #48)
> (In reply to Meridel from comment #46)
> > Prefs copy looks good and hasn't changed from what we have currently.
> >
> > Edits to close warning dialogue:
> > -Numbers less than ten should be spelled out. So if the user is closing 2 -
> > 9 tabs, spell out the number of tabs.
>
> This is really annoying to implement, and requires localizers to provide
> translations for all these numbers. It also makes it harder to scan for the
> numbers when reading the warning. It's also not clear to me that any
> convention in (American?) English that you're using here applies in other
> languages (eg I grew up in the Netherlands and the rule I got taught was to
> write out numbers under 20, as well as any numbers divisible by 10 (under
> 100) or 100 (under 1000), etc.). So it would be "five thousand tabs" but
> "5341 tabs". I would be unsurprised if other languages used other
> conventions still. It also doesn't seem related to this bug. If you feel
> strongly that this is necessary, can you file a separate bug for this, maybe
> with more details about how that should work?
>
> For the changes to the prefs:
>
> (In reply to Amy Lee [:amylee] UX from comment #44)
> > I've attached a spec for Preferences when Session Restore is Enabled and
> > Disabled. The warning will not show up by default if Session Restore is
> > enabled but I've added a pref that allows users to turn the warning message
> > on when Session Restore is enabled if desired.
>
> I have a several concerns here.
>
> First, now if users have session restore enabled there is 1 pref that
> governs both window closing and quitting. Unfortunately, there isn't a pref
> to turn on warnings for quit but not have warnings when closing multiple
> tabs otherwise. This would be desirable because it's easy to mis-hit cmd-q
> when trying to hit cmd-w (to close a tab). You have to try pretty hard to
> mis-hit cmd-shift-w (to close a window) or to close multiple tabs using the
> mouse. So I want a warning when quitting but not when closing a window, but
> I can't have that either today or with the implementation you're suggesting.
> That seems like something we should fix.

I think we are getting very specific for an issue that I think affects a small population of users. It starts to become overkill if we try to provide such specific checkbox options (ie. warn me when quitting, warn me when closing a window, etc.).

>
> Second, users who are used to the current behavior with session restore
> enabled (esp. on Windows, where mis-hitting ctrl-shift-q is also not a major
> concern) will start getting warning dialogs when we implement the new
> behavior. That seems disruptive. But we can't turn off the warning
> everywhere because then they won't get a warning when closing a window,
> which they might have relied upon. Any thoughts about how to address that?

The default settings of Session Restore would be what we have currently (not having warnings). The user can turn on the warning when closing multiple tabs in Prefs. If they accidentally close a window, it's less of a destructive action because Session Restore is enabled so if...

[Gijskruitbosch+bugs (gijskruitbosch+bugs)]

(In reply to Amy Lee [:amylee] UX from comment #49)
> (In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #48)
> > Second, users who are used to the current behavior with session restore
> > enabled (esp. on Windows, where mis-hitting ctrl-shift-q is also not a major
> > concern) will start getting warning dialogs when we implement the new
> > behavior. That seems disruptive. But we can't turn off the warning
> > everywhere because then they won't get a warning when closing a window,
> > which they might have relied upon. Any thoughts about how to address that?
>
> The default settings of Session Restore would be what we have currently (not
> having warnings).

That's not really what happens today. Today, there are warnings when closing windows, or using "close tabs to the right", or using "close other tabs" - but not when quitting, if and only if session restore is enabled.

Specifically, the preference you're suggesting we surface "under" Restore Previous Session already exists, and its default is true (ie warn when closing tabs). However, there are hardcoded checks for "does the user have session restore enabled?" in the code that avoid warning when quitting, irrespective of whether the "warn when closing tabs" checkbox is checked.

In your new design, we'd remove the hardcoded checks to ask session restore in the code that actually implements warning, and cosmetically we'd move the checkbox in about:preferences, and add some logic to tick/untick (and set/unset the pref) when the user toggles restoring their session. But that doesn't solve the conundrum here - the pref would be turned on by default, and we'd remove the checks, so then the user will start getting warnings.

We could have a one-time migration that turns off the "warn when closing tabs" pref for people who have session restore turned on, but that also seems like it'd potentially confuse users who would no longer see warnings when closing windows / multiple tabs (e.g. via "close tabs to the right") where they did see those before.

What would you prefer we do? Disable the warnings everywhere for session restore users, or accept that we'll now start warning session restore users who might not have expected this?

(In reply to Amy Lee [:amylee] UX from comment #49)
> I think we are getting very specific for an issue that I think affects a
> small population of users.

While I sympathise with the sentiment here, we already made a change in bug 1438499 (to show the same "closing multiple tabs" warning when quitting when session store is not enabled, removing a separate option to show an alternative dialog that people had to opt in to via about:config), and already people on Nightly are basically saying that that removed a "fail-safe":

(In reply to Kestrel from bug 1438499 comment #47)
> browser.showQuitWarning was a good fail-safe to avoid data loss but now that
> it has been removed a suitable replacement is needed, hopefully Bug 550559
> can be expedited to avoid a regression.

... because the "closing multiple tabs" warning on quit is enabled/disabled together with the same warning when closing windows/other/right-hand tabs, there's no way to force the quit warn...

[Mwalkington (mwalkington)]

@Gijs Okay, we can use the numerical version of numbers and NOT spell them out.

**Confirm close**
You are about to close 7 tabs. Are you sure you want to continue?

Warn me when closing multiple tabs

Cancel Close Tabs

[Amlee (amlee)]

(In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #50)
> (In reply to Amy Lee [:amylee] UX from comment #49)
> > (In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #48)
> > > Second, users who are used to the current behavior with session restore
> > > enabled (esp. on Windows, where mis-hitting ctrl-shift-q is also not a major
> > > concern) will start getting warning dialogs when we implement the new
> > > behavior. That seems disruptive. But we can't turn off the warning
> > > everywhere because then they won't get a warning when closing a window,
> > > which they might have relied upon. Any thoughts about how to address that?
> >
> > The default settings of Session Restore would be what we have currently (not
> > having warnings).
>
> That's not really what happens today. Today, there are warnings when closing
> windows, or using "close tabs to the right", or using "close other tabs" -
> but not when quitting, if and only if session restore is enabled.
>
> Specifically, the preference you're suggesting we surface "under" Restore
> Previous Session already exists, and its default is true (ie warn when
> closing tabs). However, there are hardcoded checks for "does the user have
> session restore enabled?" in the code that avoid warning when quitting,
> irrespective of whether the "warn when closing tabs" checkbox is checked.
>
> In your new design, we'd remove the hardcoded checks to ask session restore
> in the code that actually implements warning, and cosmetically we'd move the
> checkbox in about:preferences, and add some logic to tick/untick (and
> set/unset the pref) when the user toggles restoring their session. But that
> doesn't solve the conundrum here - the pref would be turned on by default,
> and we'd remove the checks, so then the user will start getting warnings.
>
> We could have a one-time migration that turns off the "warn when closing
> tabs" pref for people who have session restore turned on, but that also
> seems like it'd potentially confuse users who would no longer see warnings
> when closing windows / multiple tabs (e.g. via "close tabs to the right")
> where they did see those before.
>
> What would you prefer we do? Disable the warnings everywhere for session
> restore users, or accept that we'll now start warning session restore users
> who might not have expected this?

I would say accept that we'll now start warning session restore users about quitting. They have the option on the warning message to disable it if they want to. I've changed the wording slightly in the preference to include "quitting" when enabling warning on closing multiple tabs. If a user quits the browser with multiple tabs opened they should get this warning as well cause technically they are still closing multiple tabs when quitting. I've attached an updated spec.

[Amlee (amlee)]

Created attachment 8999195
Preferences - Close Tab Warning.png

[Mdeboer (mdeboer)]

I think :Gijs is a good mentor for this as well. I think we'd both happily take review and feedback requests!

[Gijskruitbosch+bugs (gijskruitbosch+bugs)]

*** Bug 502908 has been marked as a duplicate of this bug. ***

[Rik (riksoft)]

How is it going? In the meantime I've installed an add on to restore tabs. :-(
Hope this is not going to be passed into the standard version of FF, because at the moment the problem is only in the Developer Edition.

[Rik (riksoft)]

This bug is going to hit the standard edition... as soon as it become v63... and there is only 1 number left :-/
I think when the bug will hit the standard edition, support.mozilla.org will explode :-)

[Rik (riksoft)]

PS: are you sure this bug is the same that hide the dialog "Do you want Firefox to save your tabs for the next time it starts?"?

Because I still see the question "You are about to close 2 tabs. Are you sure you want to continue?" but I don't see the other dialog that once allowed to save the tabs.

I've checked all the flag in about:config and nothing works anymore. The question "Do you want Firefox to save your tabs for the next time it starts?" is gone.

[Gijskruitbosch+bugs (gijskruitbosch+bugs)]

Amy, this bug is still assigned to you - is there more that needs to happen design-wise or is this ready to be implemented?

[Gijskruitbosch+bugs (gijskruitbosch+bugs)]

*** Bug 1499401 has been marked as a duplicate of this bug. ***

[Amlee (amlee)]

(In reply to :Gijs (he/him) from comment #59)
> Amy, this bug is still assigned to you - is there more that needs to happen
> design-wise or is this ready to be implemented?

The design is ready to be implemented. Can you please reassign the bug to someone that implement?

[Gijskruitbosch+bugs (gijskruitbosch+bugs)]

Created attachment 9021147
Bug 550559 - also show close warnings when session restore is active, r?jaws

[Gijskruitbosch+bugs (gijskruitbosch+bugs)]

Comment on attachment 9021147
Bug 550559 - also show close warnings when session restore is active, r?jaws

(In reply to Amy Lee [:amylee] UX from comment #61)
> (In reply to :Gijs (he/him) from comment #59)
> > Amy, this bug is still assigned to you - is there more that needs to happen
> > design-wise or is this ready to be implemented?
>
> The design is ready to be implemented. Can you please reassign the bug to
> someone that implement?

OK. I attached a patch. Here are some builds to test:

Linux64: https://queue.taskcluster.net/v1/task/Zd3pnRF4QzatNAU9w4kgyw/runs/0/artifacts/public/build/target.tar.bz2

Mac: https://queue.taskcluster.net/v1/task/fNm10L8cQ_6MS4FuBly_Ag/runs/0/artifacts/public/build/target.dmg

Windows: https://queue.taskcluster.net/v1/task/TsxrJ8xgQe-pRSlpV7rgbg/runs/0/artifacts/public/build/target.zip

Can you let me know if this matches your expectations? Thank you!

[Amlee (amlee)]

Comment on attachment 9021147
Bug 550559 - also show close warnings when session restore is active, r?jaws

Hi,

I installed the mac version and I don't see an update to about:preferences under the Tabs section (“Warn you when quitting and closing multiple tabs”)

[Amlee (amlee)]

(In reply to Amy Lee [:amylee] UX from comment #65)
> Comment on attachment 9021147
> Bug 550559 - also show close warnings when session restore is active, r?jaws
>
> Hi,
>
> I installed the mac version and I don't see an update to about:preferences
> under the Tabs section (“Warn you when quitting and closing multiple tabs”)

[Gijskruitbosch+bugs (gijskruitbosch+bugs)]

(In reply to Amy Lee [:amylee] UX from comment #65)
> Comment on attachment 9021147
> Bug 550559 - also show close warnings when session restore is active, r?jaws
>
> Hi,
>
> I installed the mac version and I don't see an update to about:preferences
> under the Tabs section (“Warn you when quitting and closing multiple tabs”)

The checkbox is only visible when the user opts out of the warning. This is the existing UX today. I'm happy to change it, but the comments there implied that this was intentional, with the idea that the dialogs themselves offer a checkbox to turn this off, at which point it can be turned back on in the preferences.

Do you think the checkbox should always be visible?

[Gijskruitbosch+bugs (gijskruitbosch+bugs)]

(In reply to :Gijs (he/him) from comment #67)
> (In reply to Amy Lee [:amylee] UX from comment #65)
> > Comment on attachment 9021147
> > Bug 550559 - also show close warnings when session restore is active, r?jaws
> >
> > Hi,
> >
> > I installed the mac version and I don't see an update to about:preferences
> > under the Tabs section (“Warn you when quitting and closing multiple tabs”)
>
> The checkbox is only visible when the user opts out of the warning. This is
> the existing UX today.

Specifically, this happened in bug 1063625, and there's some discussion about it there.

[Amlee (amlee)]

(In reply to :Gijs (he/him) from comment #68)
> (In reply to :Gijs (he/him) from comment #67)
> > (In reply to Amy Lee [:amylee] UX from comment #65)
> > > Comment on attachment 9021147
> > > Bug 550559 - also show close warnings when session restore is active, r?jaws
> > >
> > > Hi,
> > >
> > > I installed the mac version and I don't see an update to about:preferences
> > > under the Tabs section (“Warn you when quitting and closing multiple tabs”)
> >
> > The checkbox is only visible when the user opts out of the warning. This is
> > the existing UX today.
>
> Specifically, this happened in bug 1063625, and there's some discussion
> about it there.

Hi,

I mean the warning text hasn't been updated to "Warn you when quitting and closing multiple tabs", right now it still reads as "Warn you when closing multiple tabs"

[Gijskruitbosch+bugs (gijskruitbosch+bugs)]

(In reply to Amy Lee [:amylee] UX from comment #69)
> (In reply to :Gijs (he/him) from comment #68)
> > (In reply to :Gijs (he/him) from comment #67)
> > > (In reply to Amy Lee [:amylee] UX from comment #65)
> > > > Comment on attachment 9021147
> > > > Bug 550559 - also show close warnings when session restore is active, r?jaws
> > > >
> > > > Hi,
> > > >
> > > > I installed the mac version and I don't see an update to about:preferences
> > > > under the Tabs section (“Warn you when quitting and closing multiple tabs”)
> > >
> > > The checkbox is only visible when the user opts out of the warning. This is
> > > the existing UX today.
> >
> > Specifically, this happened in bug 1063625, and there's some discussion
> > about it there.
>
> Hi,
>
> I mean the warning text hasn't been updated to "Warn you when quitting and
> closing multiple tabs", right now it still reads as "Warn you when closing
> multiple tabs"

Uh, I don't really understand how that's possible. https://hg.mozilla.org/try/rev/b7b641a61f5e#l3.14 shows the change to the string - the old string is no longer present. I just checked the builds produced by try myself, and I can see the new string. The string identifier also changed, so I don't really understand how it's even possible for it to show the old string. Are you sure you ran the .app from the .dmg I linked? Can you try it with a new profile?

[Gijskruitbosch+bugs (gijskruitbosch+bugs)]

Amy, have you had a chance to check the build again? These changes otherwise have r+ and are ready to land.

[Amlee (amlee)]

Comment on attachment 9021147
Bug 550559 - also show close warnings when session restore is active, r?jaws

Checked and looks good.

[Pulsebot (pulsebot)]

Pushed by <email address hidden>:
https://hg.mozilla.org/integration/autoland/rev/fd42da5a8e1a
also show close warnings when session restore is active, r=jaws,flod

[Rgurzau (rgurzau)]

https://hg.mozilla.org/mozilla-central/rev/fd42da5a8e1a

[Ben-bucksch (ben-bucksch)]

Yay, thanks so much!

[Bugzilla-tf (bugzilla-tf)]

*** Bug 1505729 has been marked as a duplicate of this bug. ***

[Pascalc (pascalc)]

Gijs, could you request an addition to our release notes? Thanks!

[Gijskruitbosch+bugs (gijskruitbosch+bugs)]

Note: we're tweaking this in bug 1506173, so subject to change, but:

Release Note Request (optional, but appreciated)
[Why is this notable]: long-standing behavior changes subtly
[Affects Firefox for Android]: no
[Suggested wording]: The "You're closing multiple tabs" warning now applies to quitting Firefox with automatic session restore turned on.
[Links (documentation, blog post, etc)]: n/a

[Pascalc (pascalc)]

Added to 65 nightly release notes with this wording:
The "Warn you when quitting and closing multiple tabs" warning now applies to quitting Firefox with automatic session restore turned on

We are keeping the 'relnote?' flag set as this is for now a nightly only note and the final wording may be different.

[Liquido2 (liquido2)]

Thanks a lot for fixing this at last!

I am gladly verifying that this is implemented in latest Nightly 65 on Linux (x86_64)

Build ID 20181205102000
User Agent Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0

[Siddhartha Sahu (siddharthasahu)]

Hi.

Does the fix not consider pinned tabs? I use multiple windows with many pinned tabs of websites I regularly use (mail, etc). Ctrl+Q only warns before quitting if there are at least 2 *unpinned* open tabs. Should it not consider pinned tabs in the count as well?

I'm using FF Developer edition 65.0b4 on Linux.

Thanks.

[Gijskruitbosch+bugs (gijskruitbosch+bugs)]

(In reply to sh.siddhartha from comment #81)
> Does the fix not consider pinned tabs? I use multiple windows with many
> pinned tabs of websites I regularly use (mail, etc). Ctrl+Q only warns
> before quitting if there are at least 2 *unpinned* open tabs. Should it not
> consider pinned tabs in the count as well?

I think so. Please file a follow-up bug.

[Siddhartha Sahu (siddharthasahu)]

Thanks for the reply. I opened https://bugzilla.mozilla.org/show_bug.cgi?id=1515061.

[Gingerbread-man-2 (gingerbread-man-2)]

*** Bug 1492598 has been marked as a duplicate of this bug. ***