commit c8cd03189a7ea38ebdd97d613a88a50d255005c2
Author: Akihiro Motoki <email address hidden>
Date: Sun Mar 12 20:55:20 2017 +0000
Use BooleanField for admin_state_up form
admin_state_up is a boolean value but the network and port edit forms
expected a string version of True/False. As a result, True/False string
was shown as the default value in these forms. The field is implemented
as ChoiceField, but there is no special reason not to use BooleanField
for a boolean field and admin_state(_up) fields are the only exceptions
in horizon. This commit replaces all admin_state(_up) fields to
use BooleanField.
As far as I checked, this pattern is used only in the networking
related panels and this patch clean them up.
Reviewed: https:/ /review. openstack. org/444670 /git.openstack. org/cgit/ openstack/ horizon/ commit/ ?id=c8cd03189a7 ea38ebdd97d613a 88a50d255005c2
Committed: https:/
Submitter: Jenkins
Branch: master
commit c8cd03189a7ea38 ebdd97d613a88a5 0d255005c2
Author: Akihiro Motoki <email address hidden>
Date: Sun Mar 12 20:55:20 2017 +0000
Use BooleanField for admin_state_up form
admin_state_up is a boolean value but the network and port edit forms
expected a string version of True/False. As a result, True/False string
was shown as the default value in these forms. The field is implemented
as ChoiceField, but there is no special reason not to use BooleanField
for a boolean field and admin_state(_up) fields are the only exceptions
in horizon. This commit replaces all admin_state(_up) fields to
use BooleanField.
As far as I checked, this pattern is used only in the networking
related panels and this patch clean them up.
Change-Id: I9286f6c29d67fe c7a88b74661bc8e ca945fd9061
Closes-Bug: #1672213