'True' is displayed in "Admin State" choice field when editing a port

[Akihiro Motoki]

The choice of Admin State field for a port is UP or DOWN, but "True" is displayed when the Edit Port form is displayed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/444670

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/444670
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c8cd03189a7ea38ebdd97d613a88a50d255005c2
Submitter: Jenkins
Branch: master

commit c8cd03189a7ea38ebdd97d613a88a50d255005c2
Author: Akihiro Motoki <email address hidden>
Date: Sun Mar 12 20:55:20 2017 +0000

    Use BooleanField for admin_state_up form

    admin_state_up is a boolean value but the network and port edit forms
    expected a string version of True/False. As a result, True/False string
    was shown as the default value in these forms. The field is implemented
    as ChoiceField, but there is no special reason not to use BooleanField
    for a boolean field and admin_state(_up) fields are the only exceptions
    in horizon. This commit replaces all admin_state(_up) fields to
    use BooleanField.

    As far as I checked, this pattern is used only in the networking
    related panels and this patch clean them up.

    Change-Id: I9286f6c29d67fec7a88b74661bc8eca945fd9061
    Closes-Bug: #1672213

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/465951

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465951
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a7ec524d4a3b74c08748c37e13825024c3b48e88
Submitter: Jenkins
Branch: stable/ocata

commit a7ec524d4a3b74c08748c37e13825024c3b48e88
Author: Akihiro Motoki <email address hidden>
Date: Sun Mar 12 20:55:20 2017 +0000

    Use BooleanField for admin_state_up form

    admin_state_up is a boolean value but the network and port edit forms
    expected a string version of True/False. As a result, True/False string
    was shown as the default value in these forms. The field is implemented
    as ChoiceField, but there is no special reason not to use BooleanField
    for a boolean field and admin_state(_up) fields are the only exceptions
    in horizon. This commit replaces all admin_state(_up) fields to
    use BooleanField.

    As far as I checked, this pattern is used only in the networking
    related panels and this patch clean them up.

    Conflicts:
     openstack_dashboard/dashboards/project/networks/ports/forms.py
     openstack_dashboard/dashboards/project/networks/workflows.py

    Closes-Bug: #1672213
    Change-Id: I9286f6c29d67fec7a88b74661bc8eca945fd9061
    (cherry picked from commit c8cd03189a7ea38ebdd97d613a88a50d255005c2)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 11.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 12.0.0.0b2 development milestone.