Comment 4 for bug 909037

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Thanks for the patch. I agree it's a bad idea to monkey patch in hg-git.

That said, dulwich is also the wrong place for this. Rather than supporting every possible form of authentication directly in Dulwich and simply passing that data on to urllib2, it would be better to allow passing in the urllib2 requests.