http default implementation doesn't support authentication

[Jelmer Vernooij]

The default dulwich http client doesn't support authentication at the moment.

HttpGitClient._perform needs to be extended to enable authentication and pass down credentials.

[Thomas Ibel (tibel)]

https://bitbucket.org/durin42/hg-git/issue/51/push-to-github-with-https-patch

[diryboy (lancevdance)]

I was not able to push to codeplex git repos using hg-git

[Dov Feldstern (dovdevel)]

This issue comes up quite often on the hg-git mailing list. Recently, a solution was posted there [1] which monkey-patches dulwich to provide support for basic authentication. However, the hg-git maintainer prefers (rightly so, as far as I understand) that the support be added in dulwich itself. This is a first attempt at porting parts of that patch into dulwich in a way that I hope makes sense.

This still requires some work -- passing in the 'authinfo' as a dictionary probably doesn't make much sense. But I hope this can serve as a basis for finally getting this fixed.

I will also post a message about this to the hg-git mailing list, along with the matching patch that needs to be applied in hg-git to make use of this.

[1] https://groups.google.com/forum/#!topic/hg-git/9clPr1wdtiw

[Jelmer Vernooij (jelmer)]

Thanks for the patch. I agree it's a bad idea to monkey patch in hg-git.

That said, dulwich is also the wrong place for this. Rather than supporting every possible form of authentication directly in Dulwich and simply passing that data on to urllib2, it would be better to allow passing in the urllib2 requests.

[Dov Feldstern (dovdevel)]

Here's a patch using urllib2's "handlers" mechanism. Now dulwich no longer needs to deal with the details of this or that authentication method -- it is up to the client (hg-git, in our case) to set up the appropriate handler(s).

[Jelmer Vernooij (jelmer)]

Thanks for the patch; handlers do seem like a very good fit here. Is there any way we can use handlers without affecting the global state? Dulwich might be loaded into another application that also uses urllib2, and so modifying the opener may have unwanted side effects.

[Dov Feldstern (dovdevel)]

Yes, it's possible to use the opener directly for opening a url, see attached (to be added *in addition* to the previous patch).

[Jelmer Vernooij (jelmer)]

Thanks, applied with some additional changes. You can now just provide a custom opener to HttpGitClient, and HttpGitClient._perform has been removed.