Disabled / insensitive menu items are not displayed

Bug #734837 reported by Mike Conley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Global menubar extension
Fix Released
Medium
Chris Coulson
thunderbird (Ubuntu)
Fix Released
Medium
Chris Coulson
Natty
Fix Released
Medium
Chris Coulson

Bug Description

I'm using Global Menu Extension 0.6.

Steps to reproduce:
1) Open Thunderbird, with Global Menu Extension installed and enabled.
2) Choose to compose a new message
3) Mouse up to the global menu bar

What happens:

The global menu bar should have File, Edit, View, Insert, Format, Options, Tools, Help (with Insert and Format disabled). Instead, I just see File, Edit, View, Options, Tools, Help, and a big gap where Insert and Format should be.

See the attached screenshot.

Revision history for this message
Mike Conley (mconley) wrote :
Revision history for this message
Xavier Guillot (valeryan-24) wrote :

In "Edit" sub-menu, text is also missing / transparent for 2 lines under Paste :

Paste Without Formatting
Paste As Quotation

Changed in globalmenu-extension:
importance: Undecided → Medium
status: New → Triaged
assignee: nobody → Chris Coulson (chrisccoulson)
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

I can't reproduce the original issue now. Mike - do you still get that?

I can reproduce the missing entries in the Edit menu though. These labels seem to only be set when the frame is drawn for the menu (which never happens with globalmenu-extension). You can test this by running with GLOBAL_MENU_DEBUG=1 and opening Thunderbirds own Edit menu first.

Changed in globalmenu-extension:
status: Triaged → In Progress
affects: Ubuntu Natty → thunderbird (Ubuntu Natty)
Changed in thunderbird (Ubuntu Natty):
assignee: nobody → Chris Coulson (chrisccoulson)
importance: Undecided → Medium
milestone: none → ubuntu-11.04-beta-2
status: New → Triaged
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Bingo!

The label isn't stored on the menuitem itself, but it's part of a command element referenced by the menuitem.

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

I've fixed this but unfortunately bzr won't let me push

Changed in globalmenu-extension:
status: In Progress → Fix Committed
Changed in thunderbird (Ubuntu Natty):
status: Triaged → Fix Committed
Changed in globalmenu-extension:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package thunderbird - 3.1.9+nobinonly-0ubuntu2

---------------
thunderbird (3.1.9+nobinonly-0ubuntu2) natty; urgency=low

  * Update globalmenu-extension code to 0.7
    - Fixes LP: #749440 - Interaction with CuteButtons extension makes
      Thunderbird abort with icons in menus. Work around this by ignoring
      icons greater than 100x100 to avoid DoS'ing unity and dbus-daemon with
      lots of icon data
    - Fixes LP: #734837 - Some menu items are not displayed. Some menuitems
      inherit a label from their command content node rather than having a
      label attribute on the menuitem content node. Make sure we use the
      right label in this case
    - Make the Alt key show the menubar in the panel
    - Drop the hacks we had to workaround the lack of menu closed signals from
      Unity. We no longer synthesize our own menu closed events, but use the
      proper event from dbusmenu.
    - In addition to this, we split the work done during menu opening in to
      2 phases - the first phase triggered off "about-to-show" and the second
      phase triggered off "opened". In the future, we should be able to delay
      the menu opening with the about-to-show handler, which is where we
      do all the work to update the menu

  * Fix LP: #719919 - no option for Thunderbird as default mail client
    - update debian/thunderbird.desktop
  * Disable the default mail client check. This seemed to always be the
    intent, but the wrong preference was being set. We correctly set
    mail.shell.checkDefaultClient to false now. This check doesn't work in
    Natty and isn't going to work unless I get time to backport gio support
    to 3.1
    - update debian/thunderbird.js
 -- Chris Coulson <email address hidden> Thu, 07 Apr 2011 00:08:36 +0100

Changed in thunderbird (Ubuntu Natty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.