Incompatibility with Thunderbird addon CuteButtons - Crystal SVG : makes TB crash when reply a mail

Bug #749440 reported by Xavier Guillot
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Global menubar extension
Fix Released
Medium
Chris Coulson
thunderbird (Ubuntu)
Fix Released
Low
Chris Coulson
Natty
Fix Released
Low
Chris Coulson

Bug Description

Hello,

There seems to be some incompatibility problem between Global Menu Bar Integration 0.6 in Thunderbird (version 3.1.9 on fresh Natty 64 beta) and Thunderbird addon CuteButtons - Crystal SVG :
https://addons.mozilla.org/fr/thunderbird/addon/cutebuttons-crystal-svg/

When both are installed and activated, it works for buttons in menus and windows, but there is a reproductible big bug :

Every time i click to "reply" to answer a mail, the window opens, but answer address, subject and quote text does not show immediately, there is a lag, then window comes but immediately after Thunderbird crashes and all TB windows close.

Happens every time I want to "Reply" a mail, absolutely no problem if I deactive or uninstall Cute Buttons Crystal SVG.

This is not a major bug as Cutebuttons is not an essential addon, but as it worked very fine until Global Menu Bar integration, I report it.

Best regards. Xavier

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Thanks. Would you mind getting a backtrace of the crash please? I tried installing cutebuttons, but I don't get any crash.

To get a backtrace, you will need to install thunderbird-dbg, and run "thunderbird -g"

Changed in globalmenu-extension:
importance: Undecided → Medium
status: New → Incomplete
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Oh, ok. I can recreate it if I turn on menu icons

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Urgh, it's aborting because this extension does something weird with icons, and it causes globalmenu-extension to send absolutely enormous amounts of data across the bus to the panel:

g_dbus_connection_real_closed: Remote peer vanished with error: Underlying GIOStream returned 0 bytes on an async read (g-io-error-quark, 0). Exiting.

Not sure what to do about this tbh. Perhaps I could add a sanity check on icons and just hide them if the icon data is unusually large

Changed in globalmenu-extension:
assignee: nobody → Chris Coulson (chrisccoulson)
status: Incomplete → Triaged
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Here is a dbus-monitor log from running tbird with this extension. You can see the ridiculous amount of icon data in there ;)

affects: Ubuntu Natty → thunderbird (Ubuntu Natty)
Changed in thunderbird (Ubuntu Natty):
assignee: nobody → Chris Coulson (chrisccoulson)
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Ok, so what this extension appears to be doing is setting list-image-style to a large image (mosaic.png), and only clips it with -moz-image-region under certain conditions (ie, when it's visible to the user). Having list-image-style=mosaic.png with no -moz-image-region is what breaks it, because it means we set the icon to the whole mosaic.png image, which is a pretty big file.

I think the only thing I can do is just disable icons when they are unusually large. In any case, this extension isn't going to do what you expect for menus with globalmenu-extension (we don't get any hover events from the menu for example)

Revision history for this message
Xavier Guillot (valeryan-24) wrote : Re: [Bug 749440] Re: Incompatibility with Thunderbird addon CuteButtons - Crystal SVG : makes TB crash when reply a mail

This extension Cutebuttons just makes icons & buttons look nicer, this
is not an essential one, I prefer to activate Global Menu if I have to
make a choice.

To solve the conflict, is there something which could be done by the
developer of Cutebuttons to correct the behavior ?

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

bzr commit -m "Limit icon sizes to 100x100, to avoid spamming the bus too much (and
> also to avoid being aborted by GDbus). Fixes LP: #749440" --fixes lp:749440
Committing to: /home/chr1s/src/globalmenu-extension/globalmenu-extension/
modified extensions/globalmenu/components/src/uGlobalMenuObject.cpp
Committed revision 126.

Changed in globalmenu-extension:
status: Triaged → Fix Committed
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

The only thing that Corebuttons could do is to stop setting the list-style-image property for menuitems to such a large image (512x400) without clipping it with a -moz-image-region property.

In any case, I've guarded against this now by bailing out from creating icons where the image is large than 100x100 (after clipping). At the moment, this seems to break icons entirely in the menu when cutebuttons is installed, although it shouldn't do. I don't think globalmenu-extension is responding to CSS property updates when the menu opens, but that is another bug.

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Ted - do you think we should add a check in to dbusmenu for this? (in dbusmenu_menuitem_property_set_image)

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Although, I guess that large icons might be ok for some consumers of dbusmenu, but not for the appmenu

Changed in thunderbird (Ubuntu Natty):
status: Triaged → Fix Committed
Changed in globalmenu-extension:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package thunderbird - 3.1.9+nobinonly-0ubuntu2

---------------
thunderbird (3.1.9+nobinonly-0ubuntu2) natty; urgency=low

  * Update globalmenu-extension code to 0.7
    - Fixes LP: #749440 - Interaction with CuteButtons extension makes
      Thunderbird abort with icons in menus. Work around this by ignoring
      icons greater than 100x100 to avoid DoS'ing unity and dbus-daemon with
      lots of icon data
    - Fixes LP: #734837 - Some menu items are not displayed. Some menuitems
      inherit a label from their command content node rather than having a
      label attribute on the menuitem content node. Make sure we use the
      right label in this case
    - Make the Alt key show the menubar in the panel
    - Drop the hacks we had to workaround the lack of menu closed signals from
      Unity. We no longer synthesize our own menu closed events, but use the
      proper event from dbusmenu.
    - In addition to this, we split the work done during menu opening in to
      2 phases - the first phase triggered off "about-to-show" and the second
      phase triggered off "opened". In the future, we should be able to delay
      the menu opening with the about-to-show handler, which is where we
      do all the work to update the menu

  * Fix LP: #719919 - no option for Thunderbird as default mail client
    - update debian/thunderbird.desktop
  * Disable the default mail client check. This seemed to always be the
    intent, but the wrong preference was being set. We correctly set
    mail.shell.checkDefaultClient to false now. This check doesn't work in
    Natty and isn't going to work unless I get time to backport gio support
    to 3.1
    - update debian/thunderbird.js
 -- Chris Coulson <email address hidden> Thu, 07 Apr 2011 00:08:36 +0100

Changed in thunderbird (Ubuntu Natty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.