In test_set_members_deleting_less_than_5[1], 3 ips are deleted from
ipset but test_set_members_deleting_less_than_5 checked that the
first one was deleted because the call ordering was non-trivial.
The test was successful because
assert_has_calls(expected_calls, any_order=False) allows extra calls
before and after expected_calls.
A parent change[2] forces the call ordering, this allows to check that
the 3 ips are deleted.
Reviewed: https:/ /review. openstack. org/185858 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=9ff8cd52462 1daf6cd20da9392 38eee14b5a231f
Committed: https:/
Submitter: Jenkins
Branch: master
commit 9ff8cd524621daf 6cd20da939238ee e14b5a231f
Author: Cedric Brandily <email address hidden>
Date: Wed May 27 08:53:00 2015 +0200
Improve test_set_ members_ deleting_ less_than_ 5
In test_set_ members_ deleting_ less_than_ 5[1], 3 ips are deleted from members_ deleting_ less_than_ 5 checked that the
ipset but test_set_
first one was deleted because the call ordering was non-trivial.
The test was successful because has_calls( expected_ calls, any_order=False) allows extra calls
assert_
before and after expected_calls.
A parent change[2] forces the call ordering, this allows to check that
the 3 ips are deleted.
[1] neutron. tests.unit. agent.linux. test_ipset_ manager 97a83c2181f38ec 1f9468df91e
[2] I8408365825ec1e
Related-Bug: #1348818
Change-Id: I773e2cd19fdec6 34b728d0c3a78c1 d66392c743f