© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Looks good to me.
I've not had time to review line-by-line, but I skimmed the patch series and it looks excellent. Unfortunately, I won't have time to test and commit just now - as I'm supposed to be working on something else. (Just checking my email at the moment).
It did occur to me (although I never tested it), that the spawn function currently in use with gsch2pcb actually passes through a shell expansion phase, so "" and \" quoting "might" have already worked - but that is very subtle and not at all obvious.
I think your patch series is superior in every way to what we had.
I REALLY want to see you get commit access so you can push changes directly (even if you still want to get them reviewed first). Please email me off list and we can see about making that happen.
Best wishes,