xgsch2pcb breaks with spaces in filenames
Bug #726828 reported by
Peter Clifton
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
gEDA |
Fix Committed
|
Medium
|
Unassigned |
Bug Description
When creating a project (in this case from a template), with a space in the project name, the template copied schematics to names which had a space in them. The resulting .gsch2pcb file was not suitably quoted, and the file-names were broken at the space.
Changed in geda: | |
assignee: | nobody → Krzysztof Kościuszkiewicz (k-kosciuszkiewicz) |
Changed in geda: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is also a gsch2pcb bug...
gsch2pcb stores the list of schematics as a space-separated list, and doesn't appear to support any form of escaping.
Since gsch2pcb launches gnetlist using g_spawn_ command_ line_sync () which processes the command-line from a string passed to it.. it seems possible that things might "just work" with judicious placement of "" quotes around schematic filenames.
Quoting the docs for that function:
On Windows, please note the implications of g_shell_ parse_argv( ) parsing command_line. Parsing is done according to Unix shell rules, not Windows command interpreter rules. Space is a separator, and backslashes are special. Thus you cannot simply pass a command_line containing canonical Windows paths, like "c:\\program files\\ app\\app. exe", as the backslashes will be eaten, and the space will act as a separator. You need to enclose such paths with single quotes, like "'c:\\program files\\ app\\app. exe' 'e:\\folder\ \argument. txt'".