xgsch2pcb breaks with spaces in filenames

[Peter Clifton]

When creating a project (in this case from a template), with a space in the project name, the template copied schematics to names which had a space in them. The resulting .gsch2pcb file was not suitably quoted, and the file-names were broken at the space.

[Peter Clifton (pcjc2)]

This is also a gsch2pcb bug...

gsch2pcb stores the list of schematics as a space-separated list, and doesn't appear to support any form of escaping.

Since gsch2pcb launches gnetlist using g_spawn_command_line_sync () which processes the command-line from a string passed to it.. it seems possible that things might "just work" with judicious placement of "" quotes around schematic filenames.

Quoting the docs for that function:

On Windows, please note the implications of g_shell_parse_argv() parsing command_line. Parsing is done according to Unix shell rules, not Windows command interpreter rules. Space is a separator, and backslashes are special. Thus you cannot simply pass a command_line containing canonical Windows paths, like "c:\\program files\\app\\app.exe", as the backslashes will be eaten, and the space will act as a separator. You need to enclose such paths with single quotes, like "'c:\\program files\\app\\app.exe' 'e:\\folder\\argument.txt'".

[Krzysztof Kościuszkiewicz (k-kosciuszkiewicz)]

Proposed fix on gsch2pcb side:
* keep a GList of .sch files instead lumping them into a single string
* allow contents of schematics option to be quoted (use g_shell_parse_argv() for that)
* replace g_spawn_command_line_sync with a helper function allowing to eliminate shell interpretation of the command line

Patch set is attached.

[Peter Clifton (pcjc2)]

Looks good to me.

I've not had time to review line-by-line, but I skimmed the patch series and it looks excellent. Unfortunately, I won't have time to test and commit just now - as I'm supposed to be working on something else. (Just checking my email at the moment).

It did occur to me (although I never tested it), that the spawn function currently in use with gsch2pcb actually passes through a shell expansion phase, so "" and \" quoting "might" have already worked - but that is very subtle and not at all obvious.

I think your patch series is superior in every way to what we had.

I REALLY want to see you get commit access so you can push changes directly (even if you still want to get them reviewed first). Please email me off list and we can see about making that happen.

Best wishes,

[Krzysztof Kościuszkiewicz (k-kosciuszkiewicz)]

I think the attached patch should be enough to have this fixed.
Windows filenames might have issues when using old project file with new code, but I saw more severe portability problems in the code right now... Also now all options are quoted when needed, but gsch2pcb only supports quoting in the schematics option.

[Krzysztof Kościuszkiewicz (k-kosciuszkiewicz)]

Commited to xgsch2pcb:
http://git.gpleda.org/?p=xgsch2pcb.git;a=commit;h=2eb0dc8b7725a3b6ef52cedd48ab631471893516

Also gsch2pcb side contains the fix since:
http://git.gpleda.org/?p=gaf.git;a=commit;h=6c4b8a72cd917872709bfb7918f9a1141d9c8548

[Vladimir Zhbanov (vzhbanov)]

We apparently have to have a separate bug tracker for xgsch2pcb (or merge it into geda gaf :-))