Comment 2 for bug 1394210

Revision history for this message
Artem Panchenko (apanchenko-8) wrote :

I think Tatyana is talking that when you try to revert environment using dos.py from snapshot which doesn't exist, it returns nothing (no output, no errors), am I right?

Such behavior was introduced by the following change:

https://review.openstack.org/#/c/125661/1/devops/driver/libvirt/libvirt_driver.py

Previously dos.py returned error if snapshot doesn't exist:

# dos.py revert fuel_test --snapshot-name bla-bla-bla
libvirt: QEMU Driver error : Domain snapshot not found: no domain snapshot with matching name 'bla-bla-bla'
libvirt: QEMU Driver error : Domain snapshot not found: no domain snapshot with matching name 'bla-bla-bla'
libvirt: QEMU Driver error : Domain snapshot not found: no domain snapshot with matching name 'bla-bla-bla'
libvirt: QEMU Driver error : Domain snapshot not found: no domain snapshot with matching name 'bla-bla-bla'

IMHO we cad add 'else' with error massage 'Domain snapshot not found: no domain snapshot with matching name {name}' here:

https://github.com/stackforge/fuel-devops/blob/master/devops/models.py#L361