Dos.py not notify any alert that we try to revert not existing snapshot

[Tatyana Dubyk]

when I've tried to revert snapshot with not existing name dos.py doesn't notify me about it.

[Andrey Danin (gcon-monolake)]

Could you provide console logs with such behavior?

[Artem Panchenko (apanchenko-8)]

I think Tatyana is talking that when you try to revert environment using dos.py from snapshot which doesn't exist, it returns nothing (no output, no errors), am I right?

Such behavior was introduced by the following change:

https://review.openstack.org/#/c/125661/1/devops/driver/libvirt/libvirt_driver.py

Previously dos.py returned error if snapshot doesn't exist:

# dos.py revert fuel_test --snapshot-name bla-bla-bla
libvirt: QEMU Driver error : Domain snapshot not found: no domain snapshot with matching name 'bla-bla-bla'
libvirt: QEMU Driver error : Domain snapshot not found: no domain snapshot with matching name 'bla-bla-bla'
libvirt: QEMU Driver error : Domain snapshot not found: no domain snapshot with matching name 'bla-bla-bla'
libvirt: QEMU Driver error : Domain snapshot not found: no domain snapshot with matching name 'bla-bla-bla'

IMHO we cad add 'else' with error massage 'Domain snapshot not found: no domain snapshot with matching name {name}' here:

https://github.com/stackforge/fuel-devops/blob/master/devops/models.py#L361

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/146896

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/146896
Committed: https://git.openstack.org/cgit/stackforge/fuel-devops/commit/?id=7191527d8acb05aa6d9e459b1478f8b4aa3cb675
Submitter: Jenkins
Branch: master

commit 7191527d8acb05aa6d9e459b1478f8b4aa3cb675
Author: asledzinskiy <email address hidden>
Date: Tue Jan 13 17:19:52 2015 +0200

    Add notification when nonexistent snapshot is reverted

    - Add notification if node doesn't have required snapshot
    - Add exception raise when some of nodes misses snapshot.
    Exception won't be raised in case of manipulation with dos.py

    Change-Id: I93b60fb3e58159de5b7c31cbbaadc608011b4aff
    Closes-Bug: #1394210