Add to my list functionality not working via the staff client

Bug #1228378 reported by Srey Seng
42
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Evergreen
Won't Fix
Medium
Unassigned

Bug Description

Evergreen Master / rel 2.4.1

From the staff client, when adding items to list and/or temporary list, a new tab opens and gives the following error:

"Redirection limit for this URL exceeded. Unable to load the requested page. This may be caused by cookies that are blocked."

Alert Message attached.

Revision history for this message
Srey Seng (sreyseng) wrote :
Revision history for this message
Ben Shum (bshum) wrote :

Marking as confirmed on master for me. Not sure about 2.4 but marking targets accordingly.

Changed in evergreen:
status: New → Triaged
status: Triaged → Confirmed
importance: Undecided → Medium
Revision history for this message
Kyle Tomita (tomitakyle) wrote :

After some quick research, the problem seems to be that ctx->{referer} is null in the sub mylist_action_redirect in EGCatLoader/Container.pm, which is causing the same page to reload and be redirected to itself.

I am still looking into this but thought this info might help others who have more knowledge of the ctx->{referer} in this situation.

Revision history for this message
Bob Wicksall (bwicksall) wrote :

Evergreen 2.7.5 still has this issue.

Revision history for this message
Bob Wicksall (bwicksall) wrote :

I traced ctx->{referer} all the way back to $ENV{HTTP_REFERER}. It's null all the way on my 2.7.5 server when connecting with the staff client. It works fine from the patron side.

Back on Evergreen 2.2.X ctx->{referer} had a valid value.

Where did $ENV{HTTP_REFERER} go?

no longer affects: evergreen/2.4
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

I don't see this issue on 2.8.4 or a 2.10.5 system.

When I click on add to list a new tab opens that displays the "You are adding to a temporary list..." message.

Josh

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Wait, I do see the same behavior on 2.10.5 after I change my prefs to not show the temporary list warning... so it is still a problem. And it might be related to the temporary list warning setting.

If the temp list warning is set to show, then you get a new window with the temp list warning instead of the redirection error.
Josh

Revision history for this message
Jason Stephenson (jstephenson) wrote :

My suggestion: Make the option disappear if ctx->{staff} is true. This feature was never really intended for the staff client anyway.

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Is there another way for staff to place multiple title level holds for one patron in batch? Right now it seem like that is possible using the my list in the staff client, it is just a little painful to use.

Revision history for this message
Kathy Lussier (klussier) wrote :

Adding a note that this is also a problem in the web client. Here is what I see in both clients.

When adding to a temporary list from the xul client, I get a blank page and the error message noted in the original description.

When adding to a temporary list from the web client, the addition to the list simply fails with no additional feedback to the user.

When adding to a permanent list from either client, adding to the list succeeds. However, the user lands on the My List page instead of staying on the search results or record summary page, which is the expected behavior we see in the public catalog.

Revision history for this message
Scott Thomas (scott-thomas-9) wrote :

This feature has indeed disappeared in 3.0 which is a bit of a problem since it is used for the carousel feature. We have instructed staff to create the carousel lists in the OPAC which is inelegant but probably workable.

Andrea Neiman (aneiman)
tags: added: webstaffclient
Revision history for this message
Kathy Lussier (klussier) wrote :

Adding a note that this feature was removed in 2.12 (and backported to earlier releases) via bug 1629016 due to the problems that were identified in this bug.

Also, when bug 1721575 is completed, we'll be seeing some changes to ways titles are added to temporary lists. We should be sure to test these actions when in the embedded catalog when that code is available.

Revision history for this message
Terran McCanna (tmccanna) wrote :

We un-hid the "Add to List" links locally even though not all the functionality is there because staff complained when it disappeared.

Revision history for this message
Jessica Woolford (jwoolford) wrote :

We unhid "Add to My List" in the staff client locally as well.

Revision history for this message
Andrea Neiman (aneiman) wrote :

Looking at this on 3.2.0, which includes the work done on bug 1721575 (Batch Actions from Search Results). One of the things this work did was build upon the "Temporary List" concept, renaming it "Basket".

So the following workflow is possible in the 3.2 staff client:

1) Search for titles
2) Use the checkboxes in the results list to add titles to the Basket
3) Using the Basket Actions menu in the upper right corner of the embedded OPAC, select the option "Add Basket to Bucket"
4) The resulting modal will prompt you to add to a new Record Bucket or an existing Record Bucket (this action is missing from the Basket Menu if you are viewing the basket & I've filed that bug separately at bug 1801995)
5) You can also perform other basket actions such as print, email, adding to permanent lists, etc.

So, asking for the above commenters: does any of the above resolve this bug from your standpoint?

Revision history for this message
Kathy Lussier (klussier) wrote :

I think the ability to add to a list from a basket resolves this specific issue. I don't think adding to a bucket was ever an issue.

However, I'm unsure why we aren't able to add to a list directly from the search results actions menu rather than being forced to go to the full basket first. It must have been something I missed in our initial testing. That probably could be a separate bug or maybe it can be tacked on to bug 1788474.

Revision history for this message
Terran McCanna (tmccanna) wrote :

I think tacking it on to bug 1788474 makes sense. I'll do that and close this one.

Changed in evergreen:
status: Confirmed → Won't Fix
Revision history for this message
Terran McCanna (tmccanna) wrote :

Marking 'won't fix' as functionality is incorporated with bug 1721575.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.