Hide Lists in Staff Client

[Christine Morgan]

It would be good to hide My Lists functions in the staff client catalog until they work in a way that we would like. (See LP#1228378)

[Christine Morgan (cmorgan-z)]

This patch hides the "Add to my list" option in the staff client.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cmorgan/lp1629016_hide_lists_staffclient

[Terran McCanna (tmccanna)]

Hi Christine,

This patch is generating a merge error. It looks like the closing END tag on line 73 of summary.tt2 needs to be before the closing DIV tag instead of after it.

Can you please update your patch?

Also, please use spaces instead of tabs - if you are using Notepad++, you can go into Settings > Tab Settings and check the box that says "Replace by space."

Thank you!
Terran

[Christine Morgan (cmorgan-z)]

I've moved the END tag and also cleaned up the tabs. Force pushed to the same branch.

Thanks Terran!

[Terran McCanna (tmccanna)]

Hi Christine,

The fix you made to summary.tt2 works great now, but it looks like the updated patch lost the parts/result/table.tt2 change you had originally included.

Terran

[Christine Morgan (cmorgan-z)]

Hi Terran,

I've included the parts/result/table.tt2 change that was missing. Force pushed to the same branch again.

Thanks so much!
Christine

[Terran McCanna (tmccanna)]

Thanks, Christine!

I tested both files (table.tt2 and summary.tt2) on a 2.12 test server.

I have tested this code and consent to signing off on it with my name, Terran McCanna, and my email address, <email address hidden>.

[Kathy Lussier (klussier)]

This patch works, but I was unable to replicate bug 1228378. Are were certain that the problem with adding to a list from the staff client still occurs?

[Kathy Lussier (klussier)]

Ignore my previous comment. I was able to replicate the issue when adding to a temporary list. Merge and signoff coming shortly.

[Kathy Lussier (klussier)]

Thank you Terran and Christine. I squashed the commits and merged them to master, release 2.11 and release 2.10. There were some minor merge conflicts on backporting that I resolved before merging.