Comment 3 for bug 915564

Hi Joe, thanks for the patch!

A couple of minor quibbles

1. Your author credit and sign-off in the patch actually shows up as "Joseph Lewis <joseph@joseph-Aspire-5745G.(none)>". This is important because you want to be appropriately credited for your contribution in the future! You can configure this in git per the info at http://evergreen-ils.org/dokuwiki/doku.php?id=dev:git#quick_start_for_evergreen_contributors so you'll be set for future contributions.

2. (not really a quibble, just a heads-up): If you sign-off on the patch (or branch, if you send in your SSH pubkey and push a branch to the working repo), then you don't need to paste a copy of the DCO in the bug, as signing-off is an acknowledgement of the DCO. We're trying to streamline things for contributors! However, for a typo fix, we don't really need to worry about a DCO.

Would you mind generating a new patch or pushing a branch with the appropriate email address for the author & sign-off lines?