"Finances" group in library settings editor is misspelled

Reported by Kathy Lussier on 2012-01-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

Evergreen 2.2alpha

Just a minor typo in the new groups in the library settings editor. Finanaces needs to be changed to Finances.

tags: added: bitesize
Joseph (joehms22) wrote :

Here is a small patch for replacing the three occurances of the misspelling in:
 - Open-ILS/src/sql/Pg/950.data.seed-values.sql
 - Open-ILS/src/sql/Pg/upgrade/0622.data.YAOUS-i18n-update.sql
 - Open-ILS/src/sql/Pg/version-upgrade/2.1-2.2-upgrade-db.sql

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Joseph Lewis <email address hidden>

Joseph (joehms22) wrote :

Slightly better formatted patch.

Dan Scott (denials) wrote :

Hi Joe, thanks for the patch!

A couple of minor quibbles

1. Your author credit and sign-off in the patch actually shows up as "Joseph Lewis <joseph@joseph-Aspire-5745G.(none)>". This is important because you want to be appropriately credited for your contribution in the future! You can configure this in git per the info at http://evergreen-ils.org/dokuwiki/doku.php?id=dev:git#quick_start_for_evergreen_contributors so you'll be set for future contributions.

2. (not really a quibble, just a heads-up): If you sign-off on the patch (or branch, if you send in your SSH pubkey and push a branch to the working repo), then you don't need to paste a copy of the DCO in the bug, as signing-off is an acknowledgement of the DCO. We're trying to streamline things for contributors! However, for a typo fix, we don't really need to worry about a DCO.

Would you mind generating a new patch or pushing a branch with the appropriate email address for the author & sign-off lines?

Joseph (joehms22) wrote :

Thanks Dan; I seemto have skipped a step after checkout. here is the new patched code.

- Joseph

Michael Peters (mrpeters) wrote :

Joe -- for future reference, a push to the evergreen-ils.org Git server is preferable to Github, as it makes it easier for folks to test, signoff, and commit your submission.

Some great information on getting started with that is available at http://evergreen-ils.org/dokuwiki/doku.php?id=dev:git

As for commit messages, at a minimum, the commit message should consist of a subject line (i.e., the first line of the commit message), then a blank line, then an optional description of the patch, followed by one or more signoffs. The subject line should be brief, ideally no more than 60-70 characters, and should include a bug number from LaunchPad if relevant. Here is an example of a minimum commit message:

LP#24544: fix the quuxifier
Signed-off-by: Jane Hacker <email address hidden>

If you need any help getting started with submitting code this way in the future, please feel free to reach out to me (or any of the other devs) via email, or the Evergreen IRC chat. (#evergreen on Freenode.net).

Thank you, again, for your quick work in solving this bug!

Dan Scott (denials) wrote :

Thanks for the updated patch, Joe - applied to master and rel_2_2. Looking forward to your continuing contributions!

Changed in evergreen:
milestone: none → 2.2.0beta1
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers