Comment 5 for bug 868653

Revision history for this message
Galen Charlton (gmc) wrote :

I like the idea of adding a user interface so that secondary permission groups can be set.

Upon reviewing the patches, I have a few comments on issues to fix:

[1] This string, "Contact <email address hidden> and tell them you saw this.", should be removed or rewritten. Unless you really do want All The Questions! ;)
[2] More seriously, the strings for the new alert messages are not translatable in their current form as they're hardcoded. They should be added to Open-ILS/web/js/dojo/openils/actor/nls/register.js so that the translation tools can reach them.
[3] Even more seriously, this patch causes a regression on the new patron expiration date button added in bug 1246853. Please redo the rebasing so that this does not happen.

I'm removing the pullrequest tag on account of these issues.