Comment 6 for bug 803121

Ok. Think I've got a fix for the previously mentioned problems in the latest branch. It appears that we're either getting undef back from users_transactions in O::A::Actor.pm or that method is crashing the drone under certain circumstances. I've added some code to check that the returned value from open-ils.actor.user.transactions.history.have_balance is reasonably sane. If it isn't, we now return a failure status and say no bills were found. This should cause the self-check to refund the patron's money.

To get the latest fix for testing, I suggest the following:

git clone git://git.evergreen-ils.org/Evergreen.git
cd Evergreen
git remote add working git://git.evergreen-ils.org/working/Evergreen.git
git fetch --all
git checkout -b SIP23738 origin/master
git cherry-pick 413cd8
git cherry-pick c5c459

Instead of the two cherry-picks you could just

git merge <email address hidden>/SIP23738

However, I recommend the cherry-picks, particularly if you based your branch on origin/rel_2_1 or origin/rel_2_0 instead of origin/master as listed above.

I won't be doing any more commit amends, so those revisions should remain unchanged.