Hold Status display and sorting

[Terran McCanna]

Hold Status only exists as a number in the logic layer. Text has to be added by the UI, which makes things like sorting really confusing.

In the View Holds interface, /app/staff/share/holds/grid.component.html controls the display text for each number that appears in the grid's Hold Status column. Sorting works, but it works by ID, so it doesn't appear to the user to work properly.

In order to get that text to appear when the grid is printed or downloaded, it also has to be added to the CellTextGenerator in grid.component.ts.

Would the best solution be another table / fm_IDL source that mapped the numbers to the desired text?

See previous related bugs:
https://bugs.launchpad.net/evergreen/+bug/1889133
https://bugs.launchpad.net/evergreen/+bug/1929565

[Galen Charlton (gmc)]

I think that making a new table could work -- and it would definitely make setting up filtering by status in the grid easy to do -- but to handle server-side sorting by the hold status label in a way that works if the label is translated, there might be some changes needed to open-ils.cstore/open-ils.pcrud's SQL generation.

[Terran McCanna (tmccanna)]

Another related bug: https://bugs.launchpad.net/evergreen/+bug/2051038

[Mike Rylander (mrylander)]

As a step in the direction of addressing this, I've pushed a branch that generates an i18n-aware ORDER BY clause when possible:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-2051037-xlate-order-by

Not adding a pullrequest tag yet, since it's only one part of the overall fix.

NOTE: this requires a "modern" OpenSRF with the renamed growing_buffer functions.