Angular Catalog view holds - sort by Status, CN Suffix, and CN Prefix results in an error

[Garry Collum]

Similar to https://bugs.launchpad.net/evergreen/+bug/1928684. In 3.6.3 and current master, when trying to sort the Status, CN Prefix, or CN Suffix columns in Staff Catalog Search > View Holds an error of "Error Retrieving Results" is displayed.

Also the CN Prefix and CN Suffix data does not display in the table. The easiest way to verify this is to add a prefix and suffix to the call number of a copy and place a copy specific hold.

[Michele Morgan (mmorgan)]

Marking Confirmed, also observed in a 3.6.1 production system.

- Sorting the grid by Status (hold status) results in "Error Retrieving Results"
- CN Prefix column contains no data
- CN Suffix column contains no data

[Michele Morgan (mmorgan)]

Transcribing Steve Callender's comments from duplicate bug 1937436:

"The issue looks to be caused by trying to order by "status_string" in the code.

no_tz.open-ils.storage.action.live_holds.wide_hash: DBD::Pg::st execute failed: ERROR: column "status_string" does not exist
LINE 222: ...78$,$_15178$2$_15178$,$_15178$4$_15178$) ORDER BY status_str...
                                                               ^ [for Statement "WITH
    t_field AS (SELECT field FROM config.display_field_map WHERE name = 'title'),
    a_field AS (SELECT field FROM config.display_field_map WHERE name = 'author')
SELECT h.id, h.request_time, h.capture_time, h.fulfillment_time, h.checkin_time,
        h.return_time, h.prev_check_time, h.expire_time, h.cancel_time, h.cancel_cause,
        h.cancel_note, h.target, h.current_copy, h.fulfillment_staff, h.fulfillment_lib,
        h.request_lib, h.requestor, h.usr, h.selection_ou, h.selection_depth, h.pickup_lib,
        h.hold_type, h.holdable_formats, h.phone_notify, h.email_notify, h.sms_notify,
        (SELECT name FROM config.sms_carrier WHERE id = h.sms_carrier) AS "sms_carrier",
        h.frozen, h.thaw_date, h.shelf_time, h.cut_in_line, h.mint_condition,
        h.shelf_expire_time, h.current_shelf_lib, h.behind_desk, h.hopeless_date,

        CASE WHEN h.cancel_time IS NOT NULL THEN 6
             WHEN h.frozen AND h.capture_time IS NULL THEN 7
             WHEN h.current_shelf_lib IS NOT NULL AND h.current_shelf_lib <> h.pickup_lib THEN 8
             WHEN h.fulfillment_time IS NOT NULL THEN 9
             WHEN h.current_copy IS NULL THEN 1
             WHEN h.capture_time"

[John Amundson (jamundson)]

Noting that in 3.7.2, I do not see an error when trying to sort by these three columns, but clicking the headers do not change the sort order of the displayed list at all.

[Chrisy Schroth (cschroth)]

Using 3-9-4 sorting by Status still brings up Error Retrieving Results. Sorting by CN Prefix did work. If the record had 2 different prefixes it did re-order the results. If all items had the same prefix it did not change the order of the holding patrons when sorting by CN Prefix.

[Andrea Neiman (aneiman)]

Confirmed still an issue in 3.11.1 with Status sort

[Terran McCanna (tmccanna)]

Noting that the proposed fix for https://bugs.launchpad.net/evergreen/+bug/1889133 stops the status sort error from occurring but will sort by the status number rather than by the text.

Sorting by the text is a lot trickier because the text doesn't actually exist in the database, it's generated in the UI. (See bug 1889133 comment 9 for more info.)

[Terran McCanna (tmccanna)]

I committed the fix for bug 1889133 and created a follow up bug for the bigger issue at https://bugs.launchpad.net/evergreen/+bug/2051037 so I'm closing this one.