Wishlist: Audit of version-upgrade scripts or inline notes

[Ryan Eby]

While auditing our database for an upgrade, I found there seems to be some upgrade scripts that are not in version-upgrades where I would expect them. I've looked over upgrade notes and can't find any regarding them that would make me think they should be skipped. If some of these scripts should not be used (or were replaced by a newer patch) then there should probably be a note in place, code removed, or code commented out. I know there are multiple bugs about better reingest notes.

Two database upgrades were included in 3.6 betas, and exist as standalone scripts, but are not included in any version upgrade. These are:

1237.data.staffcat-exclude-electronic.sql

From: https://bugs.launchpad.net/evergreen/+bug/1885767
Bug about missing version upgrade: https://bugs.launchpad.net/evergreen/+bug/1920826

1240.data.use_check_sms_notify.sql
From: https://bugs.launchpad.net/evergreen/+bug/1897146

In addition, there are patches in 3.4.4-3.4.5 and 3.5.1-3.5.2 that are not included if you follow the version upgrade path of 3.4.3-3.5.0 → 3.5.0-3.5.1 → 3.5.1-3.6.0. I'm uncertain if these were only bug fixes for those versions, but from digging, it seems like they should be included in the larger version updates. These are:

1236.lp1788260.schema.non-cat-in-house-use-aacct.sql
From: https://bugs.launchpad.net/evergreen/+bug/1788260

1238.data.permission.booking_reservation.sql
From: https://bugs.launchpad.net/evergreen/+bug/1835127

1239.data.add_missing_setting_for_booking_pull_list_grid.sql
From: https://bugs.launchpad.net/evergreen/+bug/1882825

From 3.6.0 onwards, it seems like everything is included in the larger upgrade paths. This is based off the latest 3.10 tarball.