Booking : Pull List - cannot save grid settings

Bug #1882825 reported by Christine Burns
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.4
Fix Released
Medium
Unassigned

Bug Description

EG3.4+

Booking Pull List - cannot save grid settings.

Console error = Error saving columns: No user or workstation setting type exists for: "eg.grid.booking.pull_list".
Create a ws/user setting type or use setLocalItem() to store the value locally.

Revision history for this message
Christine Burns (christine-burns) wrote :
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Here's a branch (untested) to fix this: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1882825_add_missing_setting_for_booking_pull_list_grid

Also available at sandbergja/lp1882825_add_missing_setting_for_booking_pull_list_grid

Here are some testing steps from the commit message:

[1] Go to the Booking Pull List.
[2] Change the grid around and try to save.
[3] Note in your browser console an error message: "Error saving columns: No user or workstation setting type exists for eg.grid.booking.pull_list"
[4] Run the database migration included in this commit.
[5] Repeat steps 1-2.
[6] Note that no error message appears.
[7] Try exiting Evergreen and coming back (using the same workstation). Note that your changes to the grid have stuck!

tags: added: pullrequest
Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
Changed in evergreen:
milestone: none → 3.6.1
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Revision history for this message
Tiffany Little (tslittle) wrote :

Hi Jane, could you rebase this against current master?

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Looks like this one was actually already committed back in September, and it made it into 3.4.5 and 3.5.2 (thanks, Chris!) So I'm updating this bug accordingly.

Changed in evergreen:
status: New → Fix Released
milestone: 3.6.2 → 3.5.2
importance: Undecided → Medium
Revision history for this message
Tiffany Little (tslittle) wrote :

Ha! That's probably why I had trouble with it then. :) Thanks Jane!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.