reporter: action.all_circulations_combined_types should break out non-cat in-house-use

[Chris Sharp]

Found at a PINES library that records some non-cataloged item circulations as in-house use. We have been using the action.all_circulation_combined_types source for annual reports for the last few years, but it became clear this year that the source combines non-cataloged circulations and non-cataloged in-house use circulations as non-cataloged circs. Our annual reports require our libraries to exclude in-house use when reporting total circulation.

Branch on the way.

Evergreen 3.0.2+
OpenSRF 3.0.1
PostgreSQL 9.5
Ubuntu 16.04

[Chris Sharp (chrissharp123)]

Better later than never, here's the branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1788260_non_cat_in_house_use_aacct

[Jane Sandberg (sandbergja)]

Chris, since this is a wishlist bug, could you please add some brief release notes?

[Blake GH (bmagic)]

Not sure why this is wishlist. It's a bug with existing code. Maybe it was flagged wishlist before the original code was committed to master?

[Rogan Hamby (rogan-hamby)]

signoff at user/rogan/lp1788260_non_cat_in_house_use_aacct

[Rogan Hamby (rogan-hamby)]

I'm going to take off the needs-release notes tag. I know this was tagged as wishlist but I suspect that was a misclick. This was a bug since it was the mislabeling and not addition of a new feature.

[Galen Charlton (gmc)]

Agreed, this is a bugfix, although it probably is worth a special announcement in the 3.4.x and 3.5.x release notes. Pushed to master, rel_3_5, and rel_3_4. Thanks, Chris and Rogan!