Comment 4 for bug 1995010

Revision history for this message
Mike Rylander (mrylander) wrote :

I'm not sure what "the exact same thing" is in this case. I tested filtering on the circulation modifier code in the new angular Full Reporter, and that presents a combobox which lets you choose from a list. You can do this by going all the way into the Circulation Modifier source through the tree, of course, but you can simply stop at the Item (usually called "Circulating Item" on the Circulation-type sources) branch of the source tree and using the Circulation Modifier link there immediately as a filter.

Using "name" instead of "code" for the filter won't do that, quite on purpose, because the name field is a display label and can be changed and translated, whereas code is meant to be stable. For the same reason, the "name" field is not offered as a filter in the Simple Reporter, but the stable "code" field is. Indeed, there have been requests to have translatable label fields like "name" and "description" present the the translated version in output based on the selected (or default) locale of the staff member creating the report. In that case, when there is at least one locale other than en-US loaded, those translatable label-type fields would be basically unusable as filters.

The main takeaway is that report filters, particularly in the Full Reporter, should be based on "identifier"-type fields, like code for circulation modifier, when possible. Then, where it makes sense to do so, the interface will present a selection widget.

It does look like the Simple Reporter's general filter value input component would benefit from learning some of the Full Reporter's tricks if possible, so the original report seems valid. I think the Full Reporter part may just be a matter of documentation.