Simple Reports: Circulation Modifer Name is missing from Filters

[Elizabeth Davis]

The Circulation Modifier Name is not available as a Filter in the Weeding and Collections report types in the Simple Reports. The Circulation Modifer Code is a filter option, but it does not display in a list to allow selection.

[Jennifer Pringle (jpringle-u)]

Confirming Circulation Modifier Name is not available as a filter in the Weeding and Collections report types.

In 3.9 if I add Circulation Modifier Code as a filter with the operator In List I do get a list of circ modifier codes that I can add. (For us circulation modifier name and circulation modifier code have the same values.)

[Deborah Luchenbill (deborah)]

I don't know if this needs a second bug report, but the exact same thing is happening with the angularized "regular" reports that came out with 3.13.0.

[Tina Adams (tadams222)]

Circulation Modifier in regular reports is also happening with the new upgrade to 3.13.0

[Mike Rylander (mrylander)]

I'm not sure what "the exact same thing" is in this case. I tested filtering on the circulation modifier code in the new angular Full Reporter, and that presents a combobox which lets you choose from a list. You can do this by going all the way into the Circulation Modifier source through the tree, of course, but you can simply stop at the Item (usually called "Circulating Item" on the Circulation-type sources) branch of the source tree and using the Circulation Modifier link there immediately as a filter.

Using "name" instead of "code" for the filter won't do that, quite on purpose, because the name field is a display label and can be changed and translated, whereas code is meant to be stable. For the same reason, the "name" field is not offered as a filter in the Simple Reporter, but the stable "code" field is. Indeed, there have been requests to have translatable label fields like "name" and "description" present the the translated version in output based on the selected (or default) locale of the staff member creating the report. In that case, when there is at least one locale other than en-US loaded, those translatable label-type fields would be basically unusable as filters.

The main takeaway is that report filters, particularly in the Full Reporter, should be based on "identifier"-type fields, like code for circulation modifier, when possible. Then, where it makes sense to do so, the interface will present a selection widget.

It does look like the Simple Reporter's general filter value input component would benefit from learning some of the Full Reporter's tricks if possible, so the original report seems valid. I think the Full Reporter part may just be a matter of documentation.

[Kris Stultz (stultzk)]

Reports that I could run last week are not running this week. I get an error message saying the report has failed:

DBD::Pg::st execute failed: ERROR: column 87d5ac4b596c9ba1acdb0978cb4153e0.simple_record does not exist
LINE 23: ..._record AS "6bea6961ea1f44b87109edb5259db53e" ON ("87d5ac4b5...
                                                              ^ at /openils/bin/clark-kent.pl line 256.