Holdings editor differs depending on access method

Bug #1956619 reported by Elaine Hardy
48
This bug affects 10 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.8
Fix Released
Medium
Unassigned

Bug Description

In 3.8

When accessing the holdings editor from item status or an item bucket, the old, pre 3.8, holdings editor is retrieved. When accessing if from a bib record's holding view, the new holdings editor retrieves.

See screenshot

Revision history for this message
Elaine Hardy (ehardy) wrote :
Changed in evergreen:
importance: Undecided → Medium
Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
assignee: nobody → Jeff Davis (jdavis-sitka)
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp1956619-use-ang-holdings-editor uses the Angular holdings editor when accessing it via item status (Actions > Edit > Items) or item buckets (Actions > Edit Selected Items):

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1956619-use-ang-holdings-editor

tags: added: pullrequest
Changed in evergreen:
assignee: Jeff Davis (jdavis-sitka) → nobody
Revision history for this message
Elaine Hardy (ehardy) wrote :

FYI:

We are using this bug as a workaround for https://bugs.launchpad.net/evergreen/+bug/1956626 since we can see shelving locations for the owning/circ library when it differs from the workstation library.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

In other words, before a fix for this bug is committed, we need a fix for bug 1956626?

***

In further testing of my working branch, we've found that the holdings editor doesn't always load properly. Specifically, for some users, parts of the UI (for example, the Location and Circulation attributes) are blank, and the console shows several "TypeError: c.usrname is not a function" errors. I think it's likely an issue with permission depths: the UI doesn't load properly for users who have UPDATE_COPY and other holdings-related perms at the system level, but it does load properly for users who have those perms at the consortium level. I'm not sure of the exact cause. I'm removing the pullrequest tag for now.

tags: removed: pullrequest
Revision history for this message
Elaine Hardy (ehardy) wrote :

It would be best for PINES to fix https://bugs.launchpad.net/bugs/1956626 first, yes.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Bug 1956626 has been fixed, which I think was the main blocker for getting this one resolved.

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

New branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1956619-holdings-edit-perm-failures

1. Sign-off for Jeff's commit.
2. Adds a fix to the page rendering issue noted in comment #4. The culprit was the VIEW_USER permission.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.9.1
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Lindsay Stratton (lstratton) wrote (last edit ):

Tested using https://terran-testbox.gapines.org, using admin demo login, CONS workstation, Chrome

The Angular Holdings Editor interface is retrieved from Catalog > Add Holdings, Item Status > Edit Items, and Item Bucket > Edit Selected Items.

Revision history for this message
Lindsay Stratton (lstratton) wrote :

Tested using https://terran-testbox.gapines.org/, login Concerto account br3bgreen / BR3 Cataloger, BR3 workstations, Chrome

The Angular Holdings Editor interface opens for Catalog > Add Holdings.

The earlier interface opens from Item Status > Edit Item and Item Bucket > Edit Selected Items.

Logged out, in same browser logged in using admin/cons login and now the old interface displays for Item Status and Item Bucket.

Changed in evergreen:
assignee: nobody → Mary Llewellyn (mllewell)
Revision history for this message
Mary Llewellyn (mllewell) wrote :

Tested using https://terran-testbox-gapines.org/staff, login concerto account sl1mscott/BR1 cataloger, BR1 workstation, Chrome.

Record used: Ready player one, TCN 248.
Clicked on Edit link to item MR400001716. The Angular Holdings Editor interface opened.
clicked on the View link to go to item status. Selected Action/Edit call number and item and the Angular Holdings Editor interface opened.
Went to Item Status and searched item barcode MR400001716. Selected Action/Edit call number and item and the Angular Holdings Editor interface opened.

The same happened when logged in as admin/ br1 login.

I have tested this code and consent to signing off on it with my name, Mary Llewellyn and my email address, <email address hidden>

tags: added: signedoff
Changed in evergreen:
assignee: Mary Llewellyn (mllewell) → nobody
Revision history for this message
Christine Burns (christine-burns) wrote :

Tested using https://terran-testbox.gapines.org/, admin account, BR1 workstation, chrome

The old editor still appears when adding a new record.

Click Cataloguing -> Create New MARC Record -> Add Item -> Save = old editor

Revision history for this message
Elaine Hardy (ehardy) wrote :

Tested using https://terran-testbox.gapines.org/eg/staff/login admin account, BR1 workstation, Firefox.

I am seeing the new editor in both item status and item buckets.

Revision history for this message
Terran McCanna (tmccanna) wrote :

Since the patch fixes the original bug that was reported, I think this is good to go. I've moved Christine's comment #11 into a separate launchpad ticket:

https://bugs.launchpad.net/evergreen/+bug/1982876

Revision history for this message
Michele Morgan (mmorgan) wrote :

Looks good! Pushed to master, rel_3_9 and rel_3_8.

Thanks Jeff, Bill and Mary!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.