Comment 1 for bug 1916949

Thanks for reporting this, Steve! It looks like this is happening to all comboboxes that have an idlClass and asyncSupportsEmptyTermClick="true". When a user clicks, we fetch all the data from pcrud, and get it all ready to go, we just... never display the fruits of our labors. :-)

Fix at user/sandbergja/lp1916949_async_comboboxes_show_values_on_click
Here's a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1916949_async_comboboxes_show_values_on_click

Here are testing notes from the (probably over-lengthy) commit message:

To test:
1) Apply this patch.
2) Go to Booking > Create Reservation
3) Click inside the Resource Type box.
4) Note that the available resource types display!

To make sure that asyncSupportsEmptyTermClick="false" still also
works as expected:
5) Go to Acquisitions > General Search.
6) Perform an empty search.
7) In the search results grid, some filter comboboxes have
   asyncSupportsEmptyTermClick, while others do not. For example, the
   Status column has it, so if you click in the Status filter, a list of
   possible statuses will show up. However, the Selecting User column
   (you have to enable this column) does not have it, so if you click in
   that filter, it doesn't automatically display a useless list of 100
   users.

As far as resource types that don't belong to the org owner go, that should be controlled by the VIEW_BOOKING_RESOURCE_TYPE permission. If a user has that at a consortium level, they will see all the booking resource types. If we'd like to re-think this behavior, or if that is not working consistently, I think it should be a separate ticket.