Comment 7 for bug 1908743

Thanks, Bill. Here are my testing results on current master:

This fix does remove the org units that are marked 'not a hold pickup library' from the list as advertised.

However, it still allows the system-level and consortium-level org units to be selected, which it did not in the old staff catalog. I'm not sure if that should be a separate bug, or if it should just be rolled into this one.

The public opac (and the previous staff catalog) displays the org units, but disables (and grays out) the ones that should not be selected. Looking at org_selector.tt2, it seems to be checking for a few different things on top of the 'not a hold pickup library' setting to determine whether or not the options are disabled, including org_unit.ou_type.can_have_users and org_unit.ou_type.can_have_vols.