Angular Staff Catalog ignores Not a Pickup Library setting

[Terran McCanna]

In 3.6.1 Angular Staff Catalog:

When placing a hold, it ignores the "OPAC: Org Unit is not a hold pickup library" setting and allows new holds to be placed with that branch as a pickup library.

To test:

1 - In Administration > Location Administration > Library Settings, set the "OPAC: Org Unit is not a hold pickup library" to be True for a branch

2 - Try placing a hold with that branch as the pickup library. (It should block it, but it does not.)

[Bill Erickson (berick)]

Fix pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1908743-staffcat-org-not-pickup-lib

The patch includes an API update as well, not just Angular.

Note this patch will conflict with the patch for bug #1911031, but should be trivial to resolve.

[Terran McCanna (tmccanna)]

I have tried applying this to a current master test server (and working around the change for bug 1911031) but it's not working for me.

I applied the changes, restarted apache & services, cleared cache, then set BR4 to not be a hold pickup library. BR4 still appears in the list, can still be selected, and still successfully accepts holds.

(For context, in the old version, BR4 would appear in the list but be grayed out & unselectable.)

[Terran McCanna (tmccanna)]

In addition, it is also allowing system and consortium level org units to be selected (the public OPAC does not allow this).

[Terran McCanna (tmccanna)]

Bumping to high because it's going to cause unnecessary problems.

[Jennifer Bruch (jbruchpails)]

This is a potential blocker for 3.6 for the PaILS/SPARK group.

[Terran McCanna (tmccanna)]

Found another part of the issue - in our 3.6.1 production environment, if the "not a hold pickup library" is set to False, it actually removes it from the dropdown list, which is backwards. It should remove it if it's set to True.

[Terran McCanna (tmccanna)]

Thanks, Bill. Here are my testing results on current master:

This fix does remove the org units that are marked 'not a hold pickup library' from the list as advertised.

However, it still allows the system-level and consortium-level org units to be selected, which it did not in the old staff catalog. I'm not sure if that should be a separate bug, or if it should just be rolled into this one.

The public opac (and the previous staff catalog) displays the org units, but disables (and grays out) the ones that should not be selected. Looking at org_selector.tt2, it seems to be checking for a few different things on top of the 'not a hold pickup library' setting to determine whether or not the options are disabled, including org_unit.ou_type.can_have_users and org_unit.ou_type.can_have_vols.

[Bill Erickson (berick)]

Thanks, Terran. No new bug needed.

[Bill Erickson (berick)]

Here's a new rebased branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1908743-staffcat-org-not-pickup-lib-v2

This completes the support for disabling org units in the org selector, instead of hiding them, and disables orgs that cannot have users/vols for holds placement in addition to the org setting.

[Terran McCanna (tmccanna)]

Thanks Bill, works perfectly in my testing, now! My sign off is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1908743-staffcat-org-not-pickup-lib-v2-signoff

[Galen Charlton (gmc)]

Noting some discussion with Bill today:

[17:54:15] <gmcharlt> berick: re 1908743, I've got it working, though it needed a followup to munge the OU value (otherwise false would come over as "false")
[17:54:41] <gmcharlt> however, I see a difference as compared to the embedded OPAC regarding can_have_users OU types
[17:54:57] <gmcharlt> i.e., the OPAC would allow a pickup location that allows users but not items
[17:55:43] <berick> gmcharlt: ah, that change was not intentional
[17:55:44] <gmcharlt> whereas the version in your patch disables OUs either can_have_users or can_have_copies is false
[17:57:22] <berick> i can repatch or sign off on a repatch
[17:57:33] <gmcharlt> so to confirm, OU whsoe types permits users but not items is intended as a valid pickup location?
[17:57:58] <gmcharlt> I can see that as valid - e.g., a location that has no collection but does have a hold pickup service - but I wanted to confirm
[17:58:35] <pastebot> "gmcharlt" at 168.25.130.30 pasted "berick: please go ahead and repatch; here is the additional change needed" (12 lines) at http://paste.evergreen-ils.org/10100

[Bill Erickson (berick)]

Here's new branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1908743-staffcat-org-not-pickup-lib-v3

This includes Terran's sign offs, plus new commit that addresses the issues discussed with Galen.

Thanks, All

[Terran McCanna (tmccanna)]

I've tested the latest updates as well - my sign off is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1908743-staffcat-org-not-pickup-lib-v3-signoff

[Chris Sharp (chrissharp123)]

Pushed to master and rel_3_6. Thanks, Bill and Terran!