Comment 11 for bug 1908743

Noting some discussion with Bill today:

[17:54:15] <gmcharlt> berick: re 1908743, I've got it working, though it needed a followup to munge the OU value (otherwise false would come over as "false")
[17:54:41] <gmcharlt> however, I see a difference as compared to the embedded OPAC regarding can_have_users OU types
[17:54:57] <gmcharlt> i.e., the OPAC would allow a pickup location that allows users but not items
[17:55:43] <berick> gmcharlt: ah, that change was not intentional
[17:55:44] <gmcharlt> whereas the version in your patch disables OUs either can_have_users or can_have_copies is false
[17:57:22] <berick> i can repatch or sign off on a repatch
[17:57:33] <gmcharlt> so to confirm, OU whsoe types permits users but not items is intended as a valid pickup location?
[17:57:58] <gmcharlt> I can see that as valid - e.g., a location that has no collection but does have a hold pickup service - but I wanted to confirm
[17:58:35] <pastebot> "gmcharlt" at 168.25.130.30 pasted "berick: please go ahead and repatch; here is the additional change needed" (12 lines) at http://paste.evergreen-ils.org/10100