* I think this is on the right track.
* PATRON_EXCEEDS_LONGOVERDUE_COUNT was missed. It might be nice to add a threshold_based column to config.standing_penalty so that we're not hard-coding these, but I think that can be another bug.
* There's a comment in another part of Circulate.pm that should be edited:
# ------------------------------------------------------------------------------
# Update the patron penalty info in the DB. Run it for permit-overrides
# since the penalties are not updated during the permit phase
# ------------------------------------------------------------------------------
* I wonder if the penalty calculation should be done earlier in the process (say in run_method()), and in a separate transaction. That way, the penalty would be saved in the database and available for display when reloading the patron page.
* Extra credit (and I think this is a separate bug) - more frequent updating of the patron summary box whenever something happens that might create or remove a penalty.
* This doesn't cover bug 1761560.
Upon taking an initial look:
* I think this is on the right track. EXCEEDS_ LONGOVERDUE_ COUNT was missed. It might be nice to add a threshold_based column to config. standing_ penalty so that we're not hard-coding these, but I think that can be another bug.
* PATRON_
* There's a comment in another part of Circulate.pm that should be edited:
# ------- ------- ------- ------- ------- ------- ------- ------- ------- ------- ------- - ------- ------- ------- ------- ------- ------- ------- ------- ------- ------- -
# Update the patron penalty info in the DB. Run it for permit-overrides
# since the penalties are not updated during the permit phase
# -------
* I wonder if the penalty calculation should be done earlier in the process (say in run_method()), and in a separate transaction. That way, the penalty would be saved in the database and available for display when reloading the patron page.
* Extra credit (and I think this is a separate bug) - more frequent updating of the patron summary box whenever something happens that might create or remove a penalty.
* This doesn't cover bug 1761560.