Comment 14 for bug 1850473

Revision history for this message
Stephanie Leary (stephanieleary) wrote (last edit ):

I've pushed several commits to the collab branch to deal with the accessibility issues. Most of them involved link/button issues. We're down to 72, all of which are form label problems except for two files with interaction errors that will take some more work to clean up:

staff/reporter/simple/sr-field.component.html -- there are numerous button errors here that we fixed during the work on Angular Reports (forthcoming very soon), so I'd like to leave this file alone for now rather than try to isolate those changes.

staff/admin/local/shelving_location_groups/shelving_location_groups.component.html -- the Shelving Locations admin page has a ton of accessibility errors, and I've opened a bug for that, bug 2042879. (Related, Shelving Locations Order is not great but at least passes tests now; bug 2043617 will clean that up.)

Other errors I have silenced in the latest commit:

staff/login.component.html -- aria-description is invalid. True, but only because the relevant W3C committee is lagging on adding it to the official ARIA spec. It's supported in all browsers, and I think we can just ignore this error until the spec gets updated.

share/grid/grid-body.component.html -- has to do with the single click action on grid rows. We do have a keyboard-accessible alternative to all these functions and there's no straightforward way to work around this.

staff/sandbox/sandbox.component.html -- all that's left are the deliberately bad button examples. We'll have to decide whether to move those to the wiki; for now I've disabled the relevant rules in this section.