Comment 3 for bug 1842431

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Michele, while I like the simplicity of your fix, I wonder if someone would want to display the text code in a patron notice.

I made my change to follow the principle of least surprise, i.e. the current behavior of the default template is unchanged. I added separate fields for the textcode and the description in case someone would want to display either of those individually. I'll admit that my branch is probably overkill, but I'll leave it to others to decide which fix is better, of if some combination of the two should be done, i.e. removing textcode from the reason but adding it as its own field.

Anyway, I give my signoff to your change if that's the direction that others want to go.