Comment 3 for bug 1840990

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Steven. It looks good overall. One small comment: I don't believe those two buttons in mark-missing-dialog.component.html need aria-labels. Screen readers should just announce the text inside the button tags, making the duplicate aria-label text redundant.

A good way to confirm in Firefox would be to right click on one of the buttons, select "Inspect Accessibility Properties", and confirming that the Name element is, say, "Mark Missing". In Chrome/Edge, you can similarly right click on the button, navigate from the "Styles" tab to the "Accessibility" tab, and confirm the element's accessible name is "Mark Missing".