Angular: the Mark Damaged and Mark Missing dialogs are missing some i18n directives

[Jane Sandberg]

In current master, within the experimental staff catalog, there are some English-language strings that should be marked for translation.

They are in these files:
* https://github.com/evergreen-library-system/Evergreen/blob/master/Open-ILS/src/eg2/src/app/staff/share/holdings/mark-missing-dialog.component.html
* https://github.com/evergreen-library-system/Evergreen/blob/master/Open-ILS/src/eg2/src/app/staff/share/holdings/mark-damaged-dialog.component.html

For example, the string "Title: " should be made translatable into non-English languages on this line: https://github.com/evergreen-library-system/Evergreen/blob/master/Open-ILS/src/eg2/src/app/staff/share/holdings/mark-damaged-dialog.component.html#L20

To check your work, you might:
* in the Open-ILS/src/eg2 directory, run this command: npm run export-strings
* Check the resultant Open-ILS/src/eg2/src/locale/messages.xmb file and make sure that the correct strings are included

This might be a good project for somebody new to the angular code!

[Jane Sandberg (sandbergja)]

P.S. this section from the Angular documentation is really helpful: https://angular.io/guide/i18n#template-translations

[Steven Mayo (stmayo)]

I haven't tested very rigorously as I don't have a separate locale installed yet but I think https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/smayo/lp1840990-Mark_Damaged_Mark_Missing_i18n should do it.

[Jane Sandberg (sandbergja)]

Thanks, Steven. It looks good overall. One small comment: I don't believe those two buttons in mark-missing-dialog.component.html need aria-labels. Screen readers should just announce the text inside the button tags, making the duplicate aria-label text redundant.

A good way to confirm in Firefox would be to right click on one of the buttons, select "Inspect Accessibility Properties", and confirming that the Name element is, say, "Mark Missing". In Chrome/Edge, you can similarly right click on the button, navigate from the "Styles" tab to the "Accessibility" tab, and confirm the element's accessible name is "Mark Missing".

[Steven Mayo (stmayo)]

Thanks, Jane! That's very helpful for editing other things. Every bit of advice is useful when you're learning this much.

I've undone the change to those buttons and pushed again. (after checking that they still have accessibility text)

[Jane Sandberg (sandbergja)]

Thanks for this fix, Steven! I confirmed that those strings are now being included in the xmb file, making them available for translators to work with. Pushed to the rel_3_10, rel_3_11, and main branches, for inclusion in 3.10.4, 3.11.2, and the 3.12 series.