2. I pushed a commit to add 'required' attributes to floating group and member fields so form validation will work in the editor forms.
3. I pushed another commit with a mixed bag of features, bug fixes, formatting repairs (reminder to use 'ng lint'), and nice to haves (in hopes they will be informative). Here's a breakdown from the commit:
* Added grid sorting to both group and group member grids.
* Avoid using the defaultNewRecord in fm-editor directly, by cloning it as needed, so that subsequent new records (within a single parent component instance) do not pick up values from the previously created record.
* Renamed the eg-admin-page @Input() 'hideFields' to 'hideGridFields' to better explain how the value will be passed along.
* Replace access of fieldmapper innards (thing.a[0]) with field names (thing.id())
* Remove unused <eg-string /> entries.
* Avoid unnecessary newlines in translatable strings.
* Remove unused @Inputs() and unneeded functions
* Remove unused TreeModule import
* Removed a redundant <eg-title /> -- <eg-staff-banner /> will set the title when present.
Thanks, Mike. The UI is looking great. I have reviewed your branch and pushed some additional commits:
https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ berick/ lp1840287- convert- floating- groups
1. I signed off on your commit.
2. I pushed a commit to add 'required' attributes to floating group and member fields so form validation will work in the editor forms.
3. I pushed another commit with a mixed bag of features, bug fixes, formatting repairs (reminder to use 'ng lint'), and nice to haves (in hopes they will be informative). Here's a breakdown from the commit:
* Added grid sorting to both group and group member grids.
* Avoid using the defaultNewRecord in fm-editor directly, by cloning it as needed, so that subsequent new records (within a single parent component instance) do not pick up values from the previously created record.
* Renamed the eg-admin-page @Input() 'hideFields' to 'hideGridFields' to better explain how the value will be passed along.
* Replace access of fieldmapper innards (thing.a[0]) with field names (thing.id())
* Remove unused <eg-string /> entries.
* Avoid unnecessary newlines in translatable strings.
* Remove unused @Inputs() and unneeded functions
* Remove unused TreeModule import
* Removed a redundant <eg-title /> -- <eg-staff-banner /> will set the title when present.
* Various 'ng lint' repairs.